ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-19662) Unknown attributes should not be allowed in quick link filter definitions
Date Mon, 23 Jan 2017 12:42:26 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-19662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834407#comment-15834407
] 

Hudson commented on AMBARI-19662:
---------------------------------

SUCCESS: Integrated in Jenkins build Ambari-trunk-Commit #6517 (See [https://builds.apache.org/job/Ambari-trunk-Commit/6517/])
AMBARI-19662. Unknown attributes should not be allowed in quick link (smagyari: [http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=49ba635950d2632dcac406e242df94f8a131ce2f])
* (edit) ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java
* (add) ambari-server/src/test/resources/inconsistent_quicklinks_profile_3.json
* (edit) ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileBuilderTest.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileBuilder.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParserTest.java


> Unknown attributes should not be allowed in quick link filter definitions
> -------------------------------------------------------------------------
>
>                 Key: AMBARI-19662
>                 URL: https://issues.apache.org/jira/browse/AMBARI-19662
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>    Affects Versions: trunk, 2.5.0
>            Reporter: Balázs Bence Sári
>            Assignee: Balázs Bence Sári
>             Fix For: trunk, 2.5.0
>
>         Attachments: AMBARI-19662-strict-filter-definitions_trunk_v2.patch
>
>
> When the user makes a syntax error in a quick link definition, such as:
> {code}
> { "linKKK_name": "namenode_ui", "visible": true }
> {code}
> the filter will be misinterpreted as an accept-all filter, due to the fact that the parser
would expect a proper "link_name" tag to interpret it as a link name filter. This would lead
to unexpected and difficult to debug behaviour.
> To prevent this, quick link profile evaluation should throw an exception whenever it
finds unknown tags in a filter definition



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message