Return-Path: <issues-return-34185-archive-asf-public=cust-asf.ponee.io@ambari.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id F046B200BE1
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon, 19 Dec 2016 18:04:59 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id EEDD4160B21; Mon, 19 Dec 2016 17:04:59 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 45D32160B14
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 19 Dec 2016 18:04:59 +0100 (CET)
Received: (qmail 30828 invoked by uid 500); 19 Dec 2016 17:04:58 -0000
Mailing-List: contact issues-help@ambari.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@ambari.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@ambari.apache.org>
List-Post: <mailto:issues@ambari.apache.org>
List-Id: <issues.ambari.apache.org>
Reply-To: dev@ambari.apache.org
Delivered-To: mailing list issues@ambari.apache.org
Received: (qmail 30812 invoked by uid 99); 19 Dec 2016 17:04:58 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Dec 2016 17:04:58 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 5AF3D2C0057
	for <issues@ambari.apache.org>; Mon, 19 Dec 2016 17:04:58 +0000 (UTC)
Date: Mon, 19 Dec 2016 17:04:58 +0000 (UTC)
From: "Doroszlai, Attila (JIRA)" <jira@apache.org>
To: issues@ambari.apache.org
Message-ID: <JIRA.13026976.1481286513000.555025.1482167098369@Atlassian.JIRA>
In-Reply-To: <JIRA.13026976.1481286513000@Atlassian.JIRA>
References: <JIRA.13026976.1481286513000@Atlassian.JIRA> <JIRA.13026976.1481286513314@arcas>
Subject: [jira] [Updated] (AMBARI-19149) Clean up Ambari Server source code
 warnings
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Mon, 19 Dec 2016 17:05:00 -0000


     [ https://issues.apache.org/jira/browse/AMBARI-19149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doroszlai, Attila updated AMBARI-19149:
---------------------------------------
    Attachment: AMBARI-19149-5.patch

> Clean up Ambari Server source code warnings
> -------------------------------------------
>
>                 Key: AMBARI-19149
>                 URL: https://issues.apache.org/jira/browse/AMBARI-19149
>             Project: Ambari
>          Issue Type: Task
>          Components: ambari-server
>            Reporter: Doroszlai, Attila
>            Assignee: Doroszlai, Attila
>             Fix For: 3.0.0
>
>         Attachments: AMBARI-19149-1.patch, AMBARI-19149-3.patch, AMBARI-19149-4.patch, AMBARI-19149-5.patch, IDEA_Ambari_v1.xml
>
>
> Eclipse's default warnings generated for {{ambari-server}} number roughly over 3300. Out of these, at least half of them are:
> * Unused imports
> * Type safety due to forgotten {{<>}}
> * Missing Serialization IDs from anonymous {{HashMap}} implementations
> * Unused variables
> * {{Capture<T>}} in tests
> * {{switch}} fall-through and missing {{case statements}}: *only makes changes which won't affect existing functionality*
> This makes spotting actual problems, like missing {{case}} statements a nightmare. We need to go through and clean out as many of these warnings as possible. 
> Note: With respect to the import cleanup, the IDE of choice should have the following import order setup. They should always be expanded and never use {{*}}.
> # {{java}}
> # {{javax}}
> # {{org}}
> # {{com}}
> # other



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)