Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 36A11200BD8 for ; Wed, 7 Dec 2016 11:25:01 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 33A98160B26; Wed, 7 Dec 2016 10:25:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 84439160B0A for ; Wed, 7 Dec 2016 11:25:00 +0100 (CET) Received: (qmail 29666 invoked by uid 500); 7 Dec 2016 10:24:59 -0000 Mailing-List: contact issues-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list issues@ambari.apache.org Received: (qmail 29458 invoked by uid 99); 7 Dec 2016 10:24:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Dec 2016 10:24:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 6C6452C03E5 for ; Wed, 7 Dec 2016 10:24:59 +0000 (UTC) Date: Wed, 7 Dec 2016 10:24:59 +0000 (UTC) From: "Hudson (JIRA)" To: issues@ambari.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AMBARI-18966) Add check to ensure we do not have @Transactional annotations on private methods MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 07 Dec 2016 10:25:01 -0000 [ https://issues.apache.org/jira/browse/AMBARI-18966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15728385#comment-15728385 ] Hudson commented on AMBARI-18966: --------------------------------- FAILURE: Integrated in Jenkins build Ambari-trunk-Commit #6173 (See [https://builds.apache.org/job/Ambari-trunk-Commit/6173/]) Revert "AMBARI-18966. Add check to ensure we do not have @Transactional (stoader: [http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=6806edcd94dd5568b8a21ec757fa7fa668eec71c]) * (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java * (delete) ambari-server/checkstyle.xml * (edit) ambari-server/src/main/java/org/apache/ambari/server/state/services/RetryUpgradeActionService.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java * (edit) ambari-server/pom.xml * (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java AMBARI-18966. Add check to ensure we do not have @Transactional (stoader: [http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=304a5bf6027efa9e70b1deaba325d54e586e4292]) * (add) utility/src/main/java/org/apache/ambari/checkstyle/AvoidTransactionalOnPrivateMethodsCheck.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java * (add) utility/src/test/resources/org/apache/ambari/checkstyle/InputTransactionalOnPrivateMethods.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java * (edit) ambari-server/pom.xml * (edit) utility/pom.xml * (edit) ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java * (add) ambari-server/checkstyle.xml * (add) utility/src/main/resources/checkstyle_packages.xml * (edit) pom.xml * (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java * (edit) ambari-project/pom.xml * (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java * (add) utility/src/test/java/org/apache/ambari/checkstyle/AvoidTransactionalOnPrivateMethodsCheckTest.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/state/services/RetryUpgradeActionService.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java > Add check to ensure we do not have @Transactional annotations on private methods > -------------------------------------------------------------------------------- > > Key: AMBARI-18966 > URL: https://issues.apache.org/jira/browse/AMBARI-18966 > Project: Ambari > Issue Type: Task > Components: ambari-server > Affects Versions: 2.5.0 > Reporter: Doroszlai, Attila > Assignee: Doroszlai, Attila > Priority: Critical > Fix For: 3.0.0, 2.5.0 > > Attachments: AMBARI-18966.patch > > > {{@Transactional}} methods [must not be {{private}}|https://github.com/google/guice/wiki/Transactions#method-level-transactional]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)