ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Olivér Szabó (JIRA) <j...@apache.org>
Subject [jira] [Commented] (AMBARI-19149) Clean up Ambari Server source code warnings
Date Mon, 12 Dec 2016 16:03:58 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-19149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15742324#comment-15742324
] 

Olivér Szabó commented on AMBARI-19149:
---------------------------------------

committed to trunk:
{code:java}
commit 076ed757b83a5d6907f7239f6de1334c81aeecc7
Author: Attila Doroszlai <adoroszlai@hortonworks.com>
Date:   Mon Dec 12 16:58:54 2016 +0100

    AMBARI-19149. Code cleanup: fallthrough (Attila Doroszlai via oleewere)
    
    Change-Id: I6925a08c0ebe7c12b26691646d3c335342913b2e
{code}

> Clean up Ambari Server source code warnings
> -------------------------------------------
>
>                 Key: AMBARI-19149
>                 URL: https://issues.apache.org/jira/browse/AMBARI-19149
>             Project: Ambari
>          Issue Type: Task
>          Components: ambari-server
>            Reporter: Doroszlai, Attila
>            Assignee: Doroszlai, Attila
>             Fix For: 3.0.0
>
>         Attachments: AMBARI-19149-1.patch, IDEA_Ambari_v1.xml
>
>
> Eclipse's default warnings generated for {{ambari-server}} number roughly over 3300.
Out of these, at least half of them are:
> * Unused imports
> * Type safety due to forgotten {{<>}}
> * Missing Serialization IDs from anonymous {{HashMap}} implementations
> * Unused variables
> * {{Capture<T>}} in tests
> * {{switch}} fall-through and missing {{case statements}}: *only makes changes which
won't affect existing functionality*
> This makes spotting actual problems, like missing {{case}} statements a nightmare. We
need to go through and clean out as many of these warnings as possible. 
> Note: With respect to the import cleanup, the IDE of choice should have the following
import order setup. They should always be expanded and never use {{*}}.
> # {{java}}
> # {{javax}}
> # {{org}}
> # {{com}}
> # other



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message