ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (AMBARI-19149) Clean up Ambari Server source code warnings
Date Sat, 10 Dec 2016 15:18:59 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-19149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15738018#comment-15738018
] 

Nate Cole edited comment on AMBARI-19149 at 12/10/16 3:18 PM:
--------------------------------------------------------------

Rarely (I'm assuming) will developers remember to do these commands, which will mean we'll
get all these inconsistent code warnings creeping in, likely in about a day :).  I was hoping
that it could be done as part of regular compile lifecycle.  The test phase is probably acceptable,
but we know that not everyone actually fully executes tests before pushing code.


was (Author: ncole@hortonworks.com):
Rarely (I'm assuming) will developers remember to do these commands, which will mean we'll
get all these inconsistent code warnings creeping in, likely in about a day :).  I was hoping
that it could be done as part of regular compile lifecycle.

> Clean up Ambari Server source code warnings
> -------------------------------------------
>
>                 Key: AMBARI-19149
>                 URL: https://issues.apache.org/jira/browse/AMBARI-19149
>             Project: Ambari
>          Issue Type: Task
>          Components: ambari-server
>            Reporter: Doroszlai, Attila
>            Assignee: Doroszlai, Attila
>             Fix For: 3.0.0
>
>         Attachments: AMBARI-19149-1.patch, IDEA_Ambari_v1.xml
>
>
> Eclipse's default warnings generated for {{ambari-server}} number roughly over 3300.
Out of these, at least half of them are:
> * Unused imports
> * Type safety due to forgotten {{<>}}
> * Missing Serialization IDs from anonymous {{HashMap}} implementations
> * Unused variables
> * {{Capture<T>}} in tests
> * {{switch}} fall-through and missing {{case statements}}: *only makes changes which
won't affect existing functionality*
> This makes spotting actual problems, like missing {{case}} statements a nightmare. We
need to go through and clean out as many of these warnings as possible. 
> Note: With respect to the import cleanup, the IDE of choice should have the following
import order setup. They should always be expanded and never use {{*}}.
> # {{java}}
> # {{javax}}
> # {{org}}
> # {{com}}
> # other



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message