ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-19149) Clean up Ambari Server source code warnings
Date Fri, 09 Dec 2016 19:38:59 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-19149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15736113#comment-15736113
] 

Jonathan Hurley commented on AMBARI-19149:
------------------------------------------

I too am having issues with {{utility}}. A few observations:

- Why isn't {{utility}} scoped under {{org.apache.ambari}}? Why is it just {{utility}}?
- It looks like {{utility/pom.xml}} is invalid. It includes two dependency sections for {{com.puppycrawl.tools}}
-- https://github.com/apache/ambari/blob/trunk/utility/pom.xml#L40-L50
- When I install {{utility-1.0.0.0-SNAPSHOT}}, the generated {{pom.xml}} is wrong:
-- [WARNING] The POM for org.apache.ambari:utility:jar:1.0.0.0-SNAPSHOT is invalid, transitive
dependencies (if any) will not be available: 1 problem was encountered while building the
effective model for org.apache.ambari:utility:1.0.0.0-SNAPSHOT
[ERROR] 'dependencies.dependency.version' for com.puppycrawl.tools:checkstyle:jar is missing.

- I have to manually edit this generated {{utility/pom.xml}}:
-- Replace ${checkstyle.version}} with 6.19
-- Remove partial {{dependency}} on {{com.puppycrawl.tools}}

> Clean up Ambari Server source code warnings
> -------------------------------------------
>
>                 Key: AMBARI-19149
>                 URL: https://issues.apache.org/jira/browse/AMBARI-19149
>             Project: Ambari
>          Issue Type: Task
>          Components: ambari-server
>            Reporter: Doroszlai, Attila
>            Assignee: Doroszlai, Attila
>             Fix For: 3.0.0
>
>         Attachments: AMBARI-19149-1.patch, IDEA_Ambari_v1.xml
>
>
> Eclipse's default warnings generated for {{ambari-server}} number roughly over 3300.
Out of these, at least half of them are:
> * Unused imports
> * Type safety due to forgotten {{<>}}
> * Missing Serialization IDs from anonymous {{HashMap}} implementations
> * Unused variables
> * {{Capture<T>}} in tests
> * {{switch}} fall-through and missing {{case statements}}: *only makes changes which
won't affect existing functionality*
> This makes spotting actual problems, like missing {{case}} statements a nightmare. We
need to go through and clean out as many of these warnings as possible. 
> Note: With respect to the import cleanup, the IDE of choice should have the following
import order setup. They should always be expanded and never use {{*}}.
> # {{java}}
> # {{javax}}
> # {{org}}
> # {{com}}
> # other



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message