ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-18906) Remove Unnecessary Locks Inside Of Config Business Object Implementations
Date Thu, 08 Dec 2016 01:14:59 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-18906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15730691#comment-15730691
] 

Hudson commented on AMBARI-18906:
---------------------------------

FAILURE: Integrated in Jenkins build Ambari-trunk-Commit #6179 (See [https://builds.apache.org/job/Ambari-trunk-Commit/6179/])
AMBARI-18906 - Remove Unnecessary Locks Inside Of Config Business Object (jhurley: [http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=a6639a7c72043ff7bda03e6ba305913c7503193a])
* (edit) ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HBaseConfigCalculation.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/YarnConfigCalculation.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HBaseEnvMaxDirectMemorySizeAction.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/OozieConfigCalculation.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculation.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionSchedulerThreading.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculationTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/FixOozieAdminUsersTest.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerConfigCalculationTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/agent/HeartbeatTestHelper.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/state/ConfigFactory.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/KerberosKeytabsActionTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/topology/AmbariContextTest.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/HiveZKQuorumConfigActionTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/state/Config.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/HiveEnvClasspathActionTest.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/SparkShufflePropertyConfig.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerConfigCalculation.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/configuration/RecoveryConfigHelperTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/HBaseEnvMaxDirectMemorySizeActionTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/state/ConfigGroupTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/update/HostUpdateHelperTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/utils/StageUtilsTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveEnvClasspathAction.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertReceivedListenerTest.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixOozieAdminUsers.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixLzoCodecPath.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveZKQuorumConfigAction.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/SparkShufflePropertyConfigTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java


> Remove Unnecessary Locks Inside Of Config Business Object Implementations
> -------------------------------------------------------------------------
>
>                 Key: AMBARI-18906
>                 URL: https://issues.apache.org/jira/browse/AMBARI-18906
>             Project: Ambari
>          Issue Type: Task
>          Components: ambari-server
>    Affects Versions: 2.5.0
>            Reporter: Jonathan Hurley
>            Assignee: Jonathan Hurley
>            Priority: Critical
>             Fix For: 2.5.0
>
>         Attachments: AMBARI-18906.patch
>
>
> {{ConfigImpl}} uses internal locks around state which can lead to deadlocks when this
in called in the context of other business objects. In most cases, this state-full data does
not need locks placed around it. 
> {{ConfigImpl}} should be changed to:
> - No longer store entity information
> - No longer require locks around primitive state



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message