Return-Path: <issues-return-31368-archive-asf-public=cust-asf.ponee.io@ambari.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id F0516200BD8
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Tue, 22 Nov 2016 20:39:59 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id EEFF6160B0C; Tue, 22 Nov 2016 19:39:59 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 4E615160AF1
	for <archive-asf-public@cust-asf.ponee.io>; Tue, 22 Nov 2016 20:39:59 +0100 (CET)
Received: (qmail 42151 invoked by uid 500); 22 Nov 2016 19:39:58 -0000
Mailing-List: contact issues-help@ambari.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@ambari.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@ambari.apache.org>
List-Post: <mailto:issues@ambari.apache.org>
List-Id: <issues.ambari.apache.org>
Reply-To: dev@ambari.apache.org
Delivered-To: mailing list issues@ambari.apache.org
Received: (qmail 42136 invoked by uid 99); 22 Nov 2016 19:39:58 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Nov 2016 19:39:58 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 58F0C2C002A
	for <issues@ambari.apache.org>; Tue, 22 Nov 2016 19:39:58 +0000 (UTC)
Date: Tue, 22 Nov 2016 19:39:58 +0000 (UTC)
From: "Di Li (JIRA)" <jira@apache.org>
To: issues@ambari.apache.org
Message-ID: <JIRA.13022604.1479843513000.342111.1479843598359@Atlassian.JIRA>
In-Reply-To: <JIRA.13022604.1479843513000@Atlassian.JIRA>
References: <JIRA.13022604.1479843513000@Atlassian.JIRA> <JIRA.13022604.1479843513508@arcas>
Subject: [jira] [Updated] (AMBARI-18962) Make check_package_condition in
 script.py overridable by services in stacks
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Tue, 22 Nov 2016 19:40:00 -0000


     [ https://issues.apache.org/jira/browse/AMBARI-18962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Di Li updated AMBARI-18962:
---------------------------
    Attachment: AMBARI-18962.patch

> Make check_package_condition in script.py overridable by services in stacks
> ---------------------------------------------------------------------------
>
>                 Key: AMBARI-18962
>                 URL: https://issues.apache.org/jira/browse/AMBARI-18962
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>    Affects Versions: trunk, 2.5.0
>            Reporter: Di Li
>            Assignee: Di Li
>         Attachments: AMBARI-18962.patch
>
>
> check_package_condition method in script.py was added via AMBARI-14739 to make the conditionally installing RPMs controlled jointly by metainfo.xml and functions defined in package_conditions.py.  For example, with the following metainfo.xml section. The package_conditions.py has the should_install_ams_collector function implementation.
>             <package>
>               <name>ambari-metrics-collector</name>
>               <skipUpgrade>true</skipUpgrade>
>               <condition>should_install_ams_collector</condition>
>             </package>
> The issue is that this is not easily extendable by services extensions (installed via mpack), as any third party service needs to add functions to package_conditions.py in resource_management library.
> This JIRA proposes to make check_package_condition overwritable at the service level ( by changing it from a static method to a instance method).
> Then each service can still maintain the metainfo.xml section, while implement its own check_package_condition that pulls in its own package_condition util.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)