ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doroszlai, Attila (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-18846) Custom services should be able to easily specify their own dashboards
Date Tue, 15 Nov 2016 14:11:59 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-18846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15667239#comment-15667239
] 

Doroszlai, Attila commented on AMBARI-18846:
--------------------------------------------

It does have it.  The problem occurs in {{zip_directory}}, called from the previous line.

{noformat}
$ grep -n -C5 skip_empty_directory /usr/lib/python2.6/site-packages/ambari_server/resourceFilesKeeper.py
148-  def update_directory_archive(self, directory):
149-    """
150-    If hash sum for directory is not present or differs from saved value,
151-    recalculates hash sum and creates directory archive
152-    """
153:    skip_empty_directory = True
154-    cur_hash = self.count_hash_sum(directory)
155-    saved_hash = self.read_hash_sum(directory)
156-    if cur_hash != saved_hash:
157-      if not self.nozip:
158:        self.zip_directory(directory, skip_empty_directory)
159-      # Skip generation of .hash file is directory is empty
160:      if (skip_empty_directory and (not os.path.exists(directory) or not os.listdir(directory))):
161-        self.dbg_out("Empty directory. Skipping generation of hash file for {0}".format(directory))
162-      else:
163-        self.write_hash_sum(directory, cur_hash)
164-      pass
165-
{noformat}

> Custom services should be able to easily specify their own dashboards
> ---------------------------------------------------------------------
>
>                 Key: AMBARI-18846
>                 URL: https://issues.apache.org/jira/browse/AMBARI-18846
>             Project: Ambari
>          Issue Type: Improvement
>          Components: ambari-admin, ambari-metrics, ambari-server
>    Affects Versions: trunk, 2.4.0, 2.5.0
>            Reporter: Tim Thorpe
>            Assignee: Tim Thorpe
>             Fix For: trunk, 2.5.0
>
>         Attachments: AMBARI-18846.patch
>
>
>  Currently all dashboards are added directly in under the AMBARI_METRICS package directory
(package/files/grafana-dashboards).
> In order for custom services to add dashboards, they need to add the files directly under
that folder.  Each time the Ambari server is upgraded, those files will be lost as the AMBARI_METRICS
service definition will be replaced.
> This JIRA proposes adding a new directory under the ambari-server/resources.  This will
contain both the dashboards and metrics for custom services.  
> The dashboards here will not be organized by stack.  Each service will add a directory
containing their dashboards and will add a metrics file.
> resources/dashboards/grafana-dashboards/MY_SERVICE/<dashboards>
> resources/dashboards/service-metrics/MY_SERVICE.txt
> The resources/dashboards directory will need to get sync'd to the agents.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message