ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-18846) Custom services should be able to easily specify their own dashboards
Date Mon, 14 Nov 2016 21:53:58 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-18846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665161#comment-15665161
] 

Jonathan Hurley commented on AMBARI-18846:
------------------------------------------

[~Tim Thorpe] {{branch-2.5}} still has this problem:

{code}
======================================================================
FAIL: test_update_directory_archive (TestResourceFilesKeeper.TestResourceFilesKeeper)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/jhurley/src/apache/ambari/ambari-common/src/test/python/mock/mock.py", line
1199, in patched
    return func(*args, **keywargs)
  File "/Users/jhurley/src/apache/ambari/ambari-server/src/test/python/TestResourceFilesKeeper.py",
line 191, in test_update_directory_archive
    self.assertTrue(write_hash_sum_mock.called)
AssertionError: False is not true

----------------------------------------------------------------------
Ran 270 tests in 7.216s

FAILED (failures=1)
----------------------------------------------------------------------
Failed tests:
FAIL: test_update_directory_archive (TestResourceFilesKeeper.TestResourceFilesKeeper)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/jhurley/src/apache/ambari/ambari-common/src/test/python/mock/mock.py", line
1199, in patched
    return func(*args, **keywargs)
  File "/Users/jhurley/src/apache/ambari/ambari-server/src/test/python/TestResourceFilesKeeper.py",
line 191, in test_update_directory_archive
    self.assertTrue(write_hash_sum_mock.called)
AssertionError: False is not true
{code}

Should this patch be reverted from there as well?

> Custom services should be able to easily specify their own dashboards
> ---------------------------------------------------------------------
>
>                 Key: AMBARI-18846
>                 URL: https://issues.apache.org/jira/browse/AMBARI-18846
>             Project: Ambari
>          Issue Type: Improvement
>          Components: ambari-admin, ambari-metrics, ambari-server
>    Affects Versions: trunk, 2.4.0, 2.5.0
>            Reporter: Tim Thorpe
>            Assignee: Tim Thorpe
>             Fix For: trunk, 2.5.0
>
>         Attachments: AMBARI-18846.patch
>
>
>  Currently all dashboards are added directly in under the AMBARI_METRICS package directory
(package/files/grafana-dashboards).
> In order for custom services to add dashboards, they need to add the files directly under
that folder.  Each time the Ambari server is upgraded, those files will be lost as the AMBARI_METRICS
service definition will be replaced.
> This JIRA proposes adding a new directory under the ambari-server/resources.  This will
contain both the dashboards and metrics for custom services.  
> The dashboards here will not be organized by stack.  Each service will add a directory
containing their dashboards and will add a metrics file.
> resources/dashboards/grafana-dashboards/MY_SERVICE/<dashboards>
> resources/dashboards/service-metrics/MY_SERVICE.txt
> The resources/dashboards directory will need to get sync'd to the agents.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message