Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A1122200BA3 for ; Thu, 20 Oct 2016 22:03:00 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9FC22160ACC; Thu, 20 Oct 2016 20:03:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E6C03160AF2 for ; Thu, 20 Oct 2016 22:02:59 +0200 (CEST) Received: (qmail 29049 invoked by uid 500); 20 Oct 2016 20:02:58 -0000 Mailing-List: contact issues-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list issues@ambari.apache.org Received: (qmail 29026 invoked by uid 99); 20 Oct 2016 20:02:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Oct 2016 20:02:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id BC37A2C2ABC for ; Thu, 20 Oct 2016 20:02:58 +0000 (UTC) Date: Thu, 20 Oct 2016 20:02:58 +0000 (UTC) From: "Robert Levas (JIRA)" To: issues@ambari.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (AMBARI-18635) Authorizations given to roles, should use generic role-based principals rather than hard-coded pseudo-role-based principals MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 20 Oct 2016 20:03:00 -0000 [ https://issues.apache.org/jira/browse/AMBARI-18635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Levas updated AMBARI-18635: ---------------------------------- Attachment: AMBARI-18635_trunk_02.patch AMBARI-18635_branch-2.5_02.patch AMBARI-18635_branch-2.4_02.patch > Authorizations given to roles, should use generic role-based principals rather than hard-coded pseudo-role-based principals > --------------------------------------------------------------------------------------------------------------------------- > > Key: AMBARI-18635 > URL: https://issues.apache.org/jira/browse/AMBARI-18635 > Project: Ambari > Issue Type: Bug > Components: ambari-server > Affects Versions: 2.4.0 > Reporter: Robert Levas > Assignee: Robert Levas > Fix For: 2.4.2 > > Attachments: AMBARI-18635_branch-2.4_01.patch, AMBARI-18635_branch-2.4_02.patch, AMBARI-18635_branch-2.5_01.patch, AMBARI-18635_branch-2.5_02.patch, AMBARI-18635_trunk_01.patch, AMBARI-18635_trunk_02.patch > > > Authorizations given to roles, should use generic role-based principals rather than hard-coded resource types. > Access to views can be assigned to all users with a given role. The implementation for this lead to the creation of hard-coded principals that represent the current set of roles. This is not dynamic enough for possibly future enhancements where new roles may be created by administrators. > This needs to be changed such that rather that using the hard-coded pseudo-role-principals, the dynamically generated role-principals are to be used. > The hard-coded pseudo-role-principals have the following {{adminprincipaltype}} values as opposed to "ROLE": > * ALL.CLUSTER.ADMINISTRATOR > * ALL.CLUSTER.OPERATOR > * ALL.SERVICE.ADMINISTRATOR > * ALL.SERVICE.OPERATOR > * ALL.CLUSTER.USER > These should be removed along with the associated {{adminprincipal}} records. > Also, the FE should be updated to set permissions using the dynamic role-principals. > Finally, code should be cleaned up to remove unneeded code in > * org.apache.ambari.server.security.authorization.ClusterInheritedPermissionHelper > * org.apache.ambari.server.controller.internal.GroupPrivilegeResourceProvider#getResources > * org.apache.ambari.server.controller.internal.PrivilegeResourceProvider#toEntity > * org.apache.ambari.server.controller.internal.UserPrivilegeResourceProvider#getResources > * org.apache.ambari.server.security.authorization.AuthorizationHelper#isAuthorized > * org.apache.ambari.server.view.ViewRegistry#addClusterInheritedPermissions > * ... -- This message was sent by Atlassian JIRA (v6.3.4#6332)