ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-18355) Introduce conditional dependencies in stack defition to handle blueprint validation gracefully
Date Fri, 07 Oct 2016 19:40:20 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-18355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556058#comment-15556058
] 

Nate Cole commented on AMBARI-18355:
------------------------------------

This code is breaking tests, and has been reverted from trunk.  Please fix the tests, and
also fix the formatting.  Ambari is standardized on two space tabs.  DependencyConditionInfo
is a undocumented and unformatted class.  In addition, you shouldn't be making subclasses
as internal classes of the parent abstract class.

Di Li, when you commit code on behalf of someone else, you must make the message like so:
"AMBARI-XXXXX. Some message (Joe Smith via dili)"

> Introduce conditional dependencies in stack defition to handle blueprint validation gracefully
> ----------------------------------------------------------------------------------------------
>
>                 Key: AMBARI-18355
>                 URL: https://issues.apache.org/jira/browse/AMBARI-18355
>             Project: Ambari
>          Issue Type: Improvement
>          Components: ambari-server
>    Affects Versions: trunk
>            Reporter: Amruta Borkar
>            Assignee: Amruta Borkar
>             Fix For: trunk
>
>         Attachments: AMBARI-18355.patch, AMBARI-18355_v1.patch, AMBARI-18355_v2.patch,
AMBARI-18355_v3.patch, AMBARI-18355_v4.patch, AMBARI-18355_v5.patch, Adding Conditional Dependencies.pdf
>
>
> Currently stack definitions do not list conditional dependencies, adding those to the
stack definitions would make it easy to validate errors in case of blueprint deployment. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message