Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EF873200B87 for ; Mon, 19 Sep 2016 15:18:23 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id EE23F160ABC; Mon, 19 Sep 2016 13:18:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4033F160ADC for ; Mon, 19 Sep 2016 15:18:23 +0200 (CEST) Received: (qmail 9346 invoked by uid 500); 19 Sep 2016 13:18:22 -0000 Mailing-List: contact issues-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list issues@ambari.apache.org Received: (qmail 9177 invoked by uid 99); 19 Sep 2016 13:18:22 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Sep 2016 13:18:22 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 15AD22C1B77 for ; Mon, 19 Sep 2016 13:18:22 +0000 (UTC) Date: Mon, 19 Sep 2016 13:18:22 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@ambari.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AMBARI-18415) Stack definition: service component 'cardinality' inheritance not working properly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 19 Sep 2016 13:18:24 -0000 [ https://issues.apache.org/jira/browse/AMBARI-18415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15503465#comment-15503465 ] Hadoop QA commented on AMBARI-18415: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12829179/AMBARI-18415.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The test build failed in ambari-server Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/8693//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/8693//console This message is automatically generated. > Stack definition: service component 'cardinality' inheritance not working properly > ---------------------------------------------------------------------------------- > > Key: AMBARI-18415 > URL: https://issues.apache.org/jira/browse/AMBARI-18415 > Project: Ambari > Issue Type: Bug > Reporter: Andrew Onischuk > Assignee: Andrew Onischuk > Fix For: 2.5.0 > > Attachments: AMBARI-18415.patch > > > In the stack definition if a property of service component is not defined in > one specific version than it will be inherited from the parent version. > The `ComponentInfo.cardinality` always has a default value of "0+" from the > moment the object is instantiated thus the inheritance logic is never applied. > This leads to if a specific version of a service component doesn't have a > property set in stack definition it won't inherit it from its parent but > rather will take the "0+" default value. > This is not the correct behaviour. First the inheritance should be applied and > only set `cardinality` to "0+" only if it can't be inherited from the parents > (as it's not defined in any of the parents up in the inheritance chain) -- This message was sent by Atlassian JIRA (v6.3.4#6332)