ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitry Lysnichenko (JIRA)" <j...@apache.org>
Subject [jira] [Created] (AMBARI-18350) Declare URL uniqueness in repoinfo.xml
Date Fri, 09 Sep 2016 17:02:20 GMT
Dmitry Lysnichenko created AMBARI-18350:
-------------------------------------------

             Summary: Declare URL uniqueness in repoinfo.xml
                 Key: AMBARI-18350
                 URL: https://issues.apache.org/jira/browse/AMBARI-18350
             Project: Ambari
          Issue Type: Bug
            Reporter: Dmitry Lysnichenko
            Assignee: Dmitry Lysnichenko



Repository info for a stack can contain any number of repo definitions.  For HDP, there are
two repos used (HDP and HDP-UTILS).  When checking repositories for duplicate URL, the code
does this:
{noformat}
if (! repositoryEntity.getRepositoryId().startsWith("HDP-UTILS") &&  // HDP-UTILS
is shared between repo versions
! existingRepoVersion.getId().equals(repositoryVersion.getId())) { // Allow modifying already
defined repo version
existingRepoUrls.add(repositoryEntity.getBaseUrl());
}
{noformat}

We should make the unique declaration directly for the repository so authors don't have to
guess.  This entails:
* Change {{repoinfo.xml}} to support a {{<unique>}} element within {{<repo>}}
* {{<unique>}} should apply to, say, versions of HDP that change with each release.
 Absence of said element implies {{false}} for backward compatibility.
* Change {{RepositoryVersionResourceProvider.validateRepositoryVersion(...)}} to use this
boolean for uniqueness check.
* Update the {{version_definition.xsd}} to include this new element.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message