ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-18318) Agent heartbeat handler would always handle 'UNHEALTHY' state as 'UNKNOWN'
Date Thu, 08 Sep 2016 15:42:21 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-18318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15474202#comment-15474202
] 

Hudson commented on AMBARI-18318:
---------------------------------

FAILURE: Integrated in Jenkins build Ambari-trunk-Commit #5637 (See [https://builds.apache.org/job/Ambari-trunk-Commit/5637/])
AMBARI-18318 - Agent heartbeat handler would always handle 'UNHEALTHY' (jhurley: [http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=c9a0d332e52d3abf3d8d1996187ae51c00978335])
* (edit) ambari-server/src/test/java/org/apache/ambari/server/alerts/AgentHeartbeatAlertRunnableTest.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/alerts/AgentHeartbeatAlertRunnable.java


> Agent heartbeat handler would always handle 'UNHEALTHY' state as 'UNKNOWN'
> --------------------------------------------------------------------------
>
>                 Key: AMBARI-18318
>                 URL: https://issues.apache.org/jira/browse/AMBARI-18318
>             Project: Ambari
>          Issue Type: Bug
>    Affects Versions: 2.2.2
>            Reporter: Hemanth Yamijala
>            Assignee: Hemanth Yamijala
>            Priority: Minor
>             Fix For: trunk, 2.4.1
>
>         Attachments: AMBARI-18318.patch
>
>
> From just looking at the code in {{AgentHeartbeatAlertRunnable}}:
> {code}
>         case UNHEALTHY:
>           alertState = AlertState.CRITICAL;
>           alertText = MessageFormat.format(UNHEALTHY_MSG, hostName);
>         default:
>           alertState = AlertState.UNKNOWN;
>           alertText = MessageFormat.format(UNKNOWN_MSG, hostName, hostState);
> {code}
> Note the missing break between the cases.
> Setting this as Minor, because I don't think the UNHEALTHY state is set anywhere currently.
Maybe good to fix just from hygiene perspective.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message