ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-18318) Agent heartbeat handler would always handle 'UNHEALTHY' state as 'UNKNOWN'
Date Tue, 06 Sep 2016 18:16:20 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-18318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15468101#comment-15468101
] 

Hadoop QA commented on AMBARI-18318:
------------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12827213/AMBARI-18318.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in ambari-server.

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/8586//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/8586//console

This message is automatically generated.

> Agent heartbeat handler would always handle 'UNHEALTHY' state as 'UNKNOWN'
> --------------------------------------------------------------------------
>
>                 Key: AMBARI-18318
>                 URL: https://issues.apache.org/jira/browse/AMBARI-18318
>             Project: Ambari
>          Issue Type: Bug
>            Reporter: Hemanth Yamijala
>            Assignee: Hemanth Yamijala
>            Priority: Minor
>         Attachments: AMBARI-18318.patch
>
>
> From just looking at the code in {{AgentHeartbeatAlertRunnable}}:
> {code}
>         case UNHEALTHY:
>           alertState = AlertState.CRITICAL;
>           alertText = MessageFormat.format(UNHEALTHY_MSG, hostName);
>         default:
>           alertState = AlertState.UNKNOWN;
>           alertText = MessageFormat.format(UNKNOWN_MSG, hostName, hostState);
> {code}
> Note the missing break between the cases.
> Setting this as Minor, because I don't think the UNHEALTHY state is set anywhere currently.
Maybe good to fix just from hygiene perspective.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message