Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BE7FD200B40 for ; Fri, 1 Jul 2016 22:51:12 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id BD1D1160A6C; Fri, 1 Jul 2016 20:51:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0FA89160A4D for ; Fri, 1 Jul 2016 22:51:11 +0200 (CEST) Received: (qmail 20475 invoked by uid 500); 1 Jul 2016 20:51:11 -0000 Mailing-List: contact issues-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list issues@ambari.apache.org Received: (qmail 20460 invoked by uid 99); 1 Jul 2016 20:51:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Jul 2016 20:51:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 1AB872C029E for ; Fri, 1 Jul 2016 20:51:11 +0000 (UTC) Date: Fri, 1 Jul 2016 20:51:10 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@ambari.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AMBARI-17528) Fix Logfeeder visibilities MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 01 Jul 2016 20:51:12 -0000 [ https://issues.apache.org/jira/browse/AMBARI-17528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15359606#comment-15359606 ] Hadoop QA commented on AMBARI-17528: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12815784/AMBARI-17528.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in ambari-logsearch/ambari-logsearch-logfeeder. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/7656//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/7656//console This message is automatically generated. > Fix Logfeeder visibilities > -------------------------- > > Key: AMBARI-17528 > URL: https://issues.apache.org/jira/browse/AMBARI-17528 > Project: Ambari > Issue Type: Task > Components: ambari-logsearch > Affects Versions: 2.4.0 > Reporter: Miklos Gergely > Assignee: Miklos Gergely > Fix For: 2.4.0 > > Attachments: AMBARI-17528.patch > > > Many variables/functions have a broader visibility than needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)