Return-Path: <issues-return-17162-archive-asf-public=cust-asf.ponee.io@ambari.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id D988A200B59
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri,  1 Jul 2016 18:09:12 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id D6D43160A6C; Fri,  1 Jul 2016 16:09:12 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 177EF160A6D
	for <archive-asf-public@cust-asf.ponee.io>; Fri,  1 Jul 2016 18:09:11 +0200 (CEST)
Received: (qmail 75000 invoked by uid 500); 1 Jul 2016 16:09:11 -0000
Mailing-List: contact issues-help@ambari.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@ambari.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@ambari.apache.org>
List-Post: <mailto:issues@ambari.apache.org>
List-Id: <issues.ambari.apache.org>
Reply-To: dev@ambari.apache.org
Delivered-To: mailing list issues@ambari.apache.org
Received: (qmail 74933 invoked by uid 99); 1 Jul 2016 16:09:11 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Jul 2016 16:09:11 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 044FB2C02A2
	for <issues@ambari.apache.org>; Fri,  1 Jul 2016 16:09:11 +0000 (UTC)
Date: Fri, 1 Jul 2016 16:09:11 +0000 (UTC)
From: "Keta Patel (JIRA)" <jira@apache.org>
To: issues@ambari.apache.org
Message-ID: <JIRA.12975669.1464998716000.5959.1467389351014@Atlassian.JIRA>
In-Reply-To: <JIRA.12975669.1464998716000@Atlassian.JIRA>
References: <JIRA.12975669.1464998716000@Atlassian.JIRA> <JIRA.12975669.1464998716348@arcas>
Subject: [jira] [Updated] (AMBARI-17041) Support password type for custom
 properties
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Fri, 01 Jul 2016 16:09:13 -0000


     [ https://issues.apache.org/jira/browse/AMBARI-17041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Keta Patel updated AMBARI-17041:
--------------------------------
    Status: Patch Available  (was: Open)

> Support password type for custom properties
> -------------------------------------------
>
>                 Key: AMBARI-17041
>                 URL: https://issues.apache.org/jira/browse/AMBARI-17041
>             Project: Ambari
>          Issue Type: New Feature
>          Components: ambari-server
>    Affects Versions: 2.2.2
>            Reporter: Tuong Truong
>            Assignee: Keta Patel
>         Attachments: AMBARI-17041-trunk-Jun29.patch, AMBARI-17041-trunk.patch, add_property_pop_up.tiff, cluster_config_with_password_type_in_config_attributes_column.tiff, custom_properties_after_save.tiff, custom_property_password_type.tiff, custom_property_regular_type.tiff, schema_of_clusterconfig_table.tiff
>
>
> Currently, services can define properties in the XML configuration files that is flagged as type password:
>   <property>
>         <name>my.special.password</name>
>         <value></value>
>         <property-type>PASSWORD</property-type>
>         <description>Password to be masked</description>
>     </property> 
> and it will be masked properly in the UI as well as blueprint.
> Custom property should also support this option so that password can be added as custom property and treat accordingly.
> ==========================================
> Proposed Design for the fix:
> ==========================================
> At present only the key-value information of the service properties is stored in the DB ("clusterconfig" table in the "config_data" column). 
> The "config_attributes" column stores only certain attributes like "final" indicating the list of properties set with the Final flag = true. 
> The information about the property-type (i.e PASSWORD, USER, GROUP, ADDITIONAL_USER_PROPERTY, VALUE_FROM_PROPERTY_FILE, NOT_MANAGED_HDFS_PATH, etc) is extracted from the corresponding service's property file (e.g. hive-site.xml, core-site.xml, webhcat-env.xml, etc). These files contain information of the existing properties only. Custom Properties added by ambari user have no provision to store their additional attributes. 
> Since, for this Jira we are concerned with only <property-type> attribute for Custom Properties, we could add an additional field called "Property Type" in the "Add Property" pop-up which shows up on clicking "Add Property ..." in the Custom property section for a service. For now, only 2 options are shown in the drop-down list: NONE and PASSWORD .
> A few sample test properties are created using the new "Add Property" pop-up as can be seen in the following attachments. 
> Attachments: 
> "add_property_pop_up.tiff"
> "custom_property_password_type.tiff"
> "custom_property_regular_type.tiff"
> "custom_properties_after_save.tiff"
> The <property-type> information for these Custom properties is stored in the DB in "clusterconfig" table, "config_attributes" column.
> The schema for "clusterconfig" table can be seen in the attachment:
> "schema_of_clusterconfig_table.tiff"
> The content of the "config_attributes" column with the <property-type> information from the new Custom properties can be seen in the attachment:
> "cluster_config_with_password_type_in_config_attributes_column.tiff"
> Note: The fix so far is performed only for new Custom properties. The <property-type> information for existing properties is extracted from the corresponding property xml files for the service.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)