ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-17834) HDFS copy thread in OutputHDFSFile is not removing files that are processed
Date Fri, 22 Jul 2016 07:50:20 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-17834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389117#comment-15389117
] 

Hadoop QA commented on AMBARI-17834:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12819569/AMBARI-17834.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in ambari-logsearch/ambari-logsearch-logfeeder.

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/7965//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/7965//console

This message is automatically generated.

> HDFS copy thread in OutputHDFSFile is not removing files that are processed 
> ----------------------------------------------------------------------------
>
>                 Key: AMBARI-17834
>                 URL: https://issues.apache.org/jira/browse/AMBARI-17834
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-logsearch
>    Affects Versions: 2.4.0
>            Reporter: Hemanth Yamijala
>            Assignee: Hayat Behlim
>             Fix For: 2.4.0
>
>         Attachments: AMBARI-17834.patch
>
>
> Consider the HDFS copy thread here: https://github.com/apache/ambari/blob/trunk/ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputHDFSFile.java#L177
> It uses a data structure localReadyFiles that has the list of files to copy to HDFS.
But AFAICS, nowhere are processed files removed from this data structure. This could result
in multiple incorrect behaviours:
> * Over a period of time, this structure could keep growing indefinitely. While the check
for existence of files will allow progress, it will take longer and longer to run.
> *  The check to wait when there are no files to process will never pass because the size
of the data structure will never be 0. This could lead to tight looped checks and some utilization
issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message