ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-17445) Storm metrics sink: expand metrics name to contain additional informations
Date Mon, 04 Jul 2016 15:20:10 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-17445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361448#comment-15361448
] 

Hadoop QA commented on AMBARI-17445:
------------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12816032/AMBARI-17445-v4.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in ambari-metrics/ambari-metrics-storm-sink
ambari-metrics/ambari-metrics-storm-sink-legacy.

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/7680//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/7680//console

This message is automatically generated.

> Storm metrics sink: expand metrics name to contain additional informations
> --------------------------------------------------------------------------
>
>                 Key: AMBARI-17445
>                 URL: https://issues.apache.org/jira/browse/AMBARI-17445
>             Project: Ambari
>          Issue Type: Improvement
>          Components: ambari-metrics
>    Affects Versions: 2.4.0
>            Reporter: Jungtaek Lim
>         Attachments: AMBARI-17445-changes.png, AMBARI-17445-v1.patch, AMBARI-17445-v2.patch,
AMBARI-17445-v3.patch, AMBARI-17445-v4.patch
>
>
> With AMBARI-16946 we expanded metric name to have component name, task id, and key when
type of metric value is Map. Topology name was placed to appId.
> While talking with [~prajwal] and [~harsha_ch], we found that we should move out all
necessary informations like topology name, worker host, worker port to metric name so that
they can be templatized.
> This also supercedes AMBARI-17249 since all metrics will include worker host and worker
port to metric name.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message