Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B7DBD200AE4 for ; Fri, 10 Jun 2016 00:22:24 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B69F2160A59; Thu, 9 Jun 2016 22:22:24 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 15E56160A58 for ; Fri, 10 Jun 2016 00:22:23 +0200 (CEST) Received: (qmail 37977 invoked by uid 500); 9 Jun 2016 22:22:22 -0000 Mailing-List: contact issues-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list issues@ambari.apache.org Received: (qmail 37812 invoked by uid 99); 9 Jun 2016 22:22:22 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Jun 2016 22:22:22 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 56F912C1F6A for ; Thu, 9 Jun 2016 22:22:22 +0000 (UTC) Date: Thu, 9 Jun 2016 22:22:22 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@ambari.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AMBARI-17149) HadoopTimelineMetricsSink from AMS prevents process shutdown MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 09 Jun 2016 22:22:24 -0000 [ https://issues.apache.org/jira/browse/AMBARI-17149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323493#comment-15323493 ] Hadoop QA commented on AMBARI-17149: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12809286/AMBARI-17149.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in ambari-metrics/ambari-metrics-hadoop-sink. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/7282//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/7282//console This message is automatically generated. > HadoopTimelineMetricsSink from AMS prevents process shutdown > ------------------------------------------------------------ > > Key: AMBARI-17149 > URL: https://issues.apache.org/jira/browse/AMBARI-17149 > Project: Ambari > Issue Type: Bug > Components: ambari-metrics > Affects Versions: 2.4.0 > Reporter: Aravindan Vijayan > Assignee: Aravindan Vijayan > Priority: Critical > Fix For: 2.4.0 > > Attachments: AMBARI-17149.patch > > > HadoopTimelineMetricsSink has and ExecutorService thread which is not a daemon thread. The executor is not shutdown, and thread is not interrupted while the sink stops. This causes region server process to hang although the rest of the threads have all exited. > The new thread should be marked as a daemon thread, and also call shutdown() or shutdownNow() on the executor in sink close. -- This message was sent by Atlassian JIRA (v6.3.4#6332)