Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BED8D200AF7 for ; Tue, 14 Jun 2016 17:45:02 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id BD85F160A47; Tue, 14 Jun 2016 15:45:02 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 13F9E160A06 for ; Tue, 14 Jun 2016 17:45:01 +0200 (CEST) Received: (qmail 60250 invoked by uid 500); 14 Jun 2016 15:45:01 -0000 Mailing-List: contact issues-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list issues@ambari.apache.org Received: (qmail 60234 invoked by uid 99); 14 Jun 2016 15:45:01 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Jun 2016 15:45:01 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 2F41C2C14F9 for ; Tue, 14 Jun 2016 15:45:01 +0000 (UTC) Date: Tue, 14 Jun 2016 15:45:01 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@ambari.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AMBARI-17146) Implement config values trimming for deployment via blueprint MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 14 Jun 2016 15:45:02 -0000 [ https://issues.apache.org/jira/browse/AMBARI-17146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15329691#comment-15329691 ] Hadoop QA commented on AMBARI-17146: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12810391/AMBARI-17146_2.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in ambari-server: org.apache.ambari.server.controller.internal.StackTest Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/7346//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/7346//console This message is automatically generated. > Implement config values trimming for deployment via blueprint > ------------------------------------------------------------- > > Key: AMBARI-17146 > URL: https://issues.apache.org/jira/browse/AMBARI-17146 > Project: Ambari > Issue Type: Task > Affects Versions: 2.4.0 > Reporter: Dmytro Sen > Assignee: Dmytro Sen > Priority: Critical > Fix For: 2.4.0 > > Attachments: AMBARI-17146_2.patch > > > Implement config values trimming for deployment via blueprint as we do in UI > {code} > trimProperty: function (property) { > var displayType = Em.get(property, 'displayType'); > var value = Em.get(property, 'value'); > var name = Em.get(property, 'name'); > var rez; > switch (displayType) { > case 'directories': > case 'directory': > rez = value.replace(/,/g, ' ').trim().split(/\s+/g).join(','); > break; > case 'host': > rez = value.trim(); > break; > case 'password': > break; > default: > if (name == 'javax.jdo.option.ConnectionURL' || name == 'oozie.service.JPAService.jdbc.url') { > rez = value.trim(); > } > rez = (typeof value == 'string') ? value.replace(/(\s+$)/g, '') : value; > } > return ((rez == '') || (rez == undefined)) ? value : rez; > }, > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)