ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-17149) HadoopTimelineMetricsSink from AMS prevents process shutdown
Date Thu, 09 Jun 2016 22:22:22 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-17149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323493#comment-15323493
] 

Hadoop QA commented on AMBARI-17149:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12809286/AMBARI-17149.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in ambari-metrics/ambari-metrics-hadoop-sink.

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/7282//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/7282//console

This message is automatically generated.

> HadoopTimelineMetricsSink from AMS prevents process shutdown
> ------------------------------------------------------------
>
>                 Key: AMBARI-17149
>                 URL: https://issues.apache.org/jira/browse/AMBARI-17149
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-metrics
>    Affects Versions: 2.4.0
>            Reporter: Aravindan Vijayan
>            Assignee: Aravindan Vijayan
>            Priority: Critical
>             Fix For: 2.4.0
>
>         Attachments: AMBARI-17149.patch
>
>
> HadoopTimelineMetricsSink has and ExecutorService thread which is not a daemon thread.
The executor is not shutdown, and thread is not interrupted while the sink stops. This causes
region server process to hang although the rest of the threads have all exited.
> The new thread should be marked as a daemon thread, and also call shutdown() or shutdownNow()
on the executor in sink close.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message