Mailing-List: contact issues-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Date: Mon, 30 May 2016 16:38:12 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@ambari.apache.org
Message-ID: <JIRA.12973981.1464614976000.332355.1464626292813@Atlassian.JIRA>
In-Reply-To: <JIRA.12973981.1464614976000@Atlassian.JIRA>
References: <JIRA.12973981.1464614976000@Atlassian.JIRA> <JIRA.12973981.1464614976845@arcas>
Subject: [jira] [Commented] (AMBARI-16954) SERVICE_CHECK Upgrade pre-check
 does not throw error when its expected to
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 30 May 2016 16:38:15 -0000


    [ https://issues.apache.org/jira/browse/AMBARI-16954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15306807#comment-15306807 ] 

Hadoop QA commented on AMBARI-16954:
------------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12806977/AMBARI-16954.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in ambari-server.

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/7058//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/7058//console

This message is automatically generated.

> SERVICE_CHECK Upgrade pre-check does not throw error when its expected to
> -------------------------------------------------------------------------
>
>                 Key: AMBARI-16954
>                 URL: https://issues.apache.org/jira/browse/AMBARI-16954
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>    Affects Versions: 2.4.0
>            Reporter: Dmitry Lysnichenko
>            Assignee: Dmitry Lysnichenko
>             Fix For: 2.4.0
>
>         Attachments: AMBARI-16954.patch
>
>
> *Steps*
> # Deploy HDP-2.4.0.0 cluster with Ambari 2.2.2
> # Upgrade Ambari to 2.4.0.0
> # Register HDP-2.5.0.0 version and install the bits
> # Modify configs for some of the service like HDFS, ZK, YARN
> # Start EU
> *Result*:
> EU pre-check does *not* report below error for the three services whose config was modified in step 4
> "The following service configurations have been updated and their Service Checks should be run again:"
> Upon further investigation found that the pre-check does not work if a service check has never been run for a service at all AND reports success in such cases
> In other words, the comparison between last config modification time and last service check time succeeds if service check never ran at all and the output of below query returns empty:
> {code}
> SELECT start_time FROM host_role_command where role = 'HDFS_SERVICE_CHECK' AND status = 'COMPLETED' ORDER BY start_time DESC;
> {code}
> In this case when I manually ran a service check for HDFS and retried EU, the pre-check caught the mismatch and reported error
> *Note*: I believe we do run service check as part of cluster install, but looks like it does not get updated in the DB tables for all services.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)