Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B2FA5200AF6 for ; Fri, 27 May 2016 09:34:14 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B1B6316099F; Fri, 27 May 2016 07:34:14 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 03F9D160A12 for ; Fri, 27 May 2016 09:34:13 +0200 (CEST) Received: (qmail 59511 invoked by uid 500); 27 May 2016 07:34:13 -0000 Mailing-List: contact issues-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list issues@ambari.apache.org Received: (qmail 59494 invoked by uid 99); 27 May 2016 07:34:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 May 2016 07:34:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id E59362C14DC for ; Fri, 27 May 2016 07:34:12 +0000 (UTC) Date: Fri, 27 May 2016 07:34:12 +0000 (UTC) From: "Hudson (JIRA)" To: issues@ambari.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AMBARI-16919) Handle the scenario when 'capacity-scheduler' is passed-in as dictionary to Stack Advisor and services['configurations']["capacity-scheduler"]["properties"]["capacity-scheduler"] is null. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 27 May 2016 07:34:14 -0000 [ https://issues.apache.org/jira/browse/AMBARI-16919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303710#comment-15303710 ] Hudson commented on AMBARI-16919: --------------------------------- ABORTED: Integrated in Ambari-trunk-Commit #4938 (See [https://builds.apache.org/job/Ambari-trunk-Commit/4938/]) AMBARI-16919. Handle the scenario when 'capacity-scheduler' is passed-in (sshridhar: [http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=59364bc87d0ad3c6fa16918329d40230b34646c8]) * ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java * ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py * ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > Handle the scenario when 'capacity-scheduler' is passed-in as dictionary to Stack Advisor and services['configurations']["capacity-scheduler"]["properties"]["capacity-scheduler"] is null. > ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- > > Key: AMBARI-16919 > URL: https://issues.apache.org/jira/browse/AMBARI-16919 > Project: Ambari > Issue Type: Bug > Components: ambari-server > Affects Versions: 2.4.0 > Reporter: Swapan Shridhar > Assignee: Swapan Shridhar > Priority: Blocker > Fix For: 2.4.0 > > Attachments: AMBARI-16919.patch > > > AMBARI-16888 handled the scenario when capacity-scheduler is passed in as dictionary and services['configurations']["capacity-scheduler"]["properties"]["capacity-scheduler"] set as value = "null". > {code} > "capacity-scheduler" : { > "properties" : { > "capacity-scheduler" : "null", > "yarn.scheduler.capacity.root.accessible-node-labels" : "*", > "yarn.scheduler.capacity.maximum-am-resource-percent" : "1", > "yarn.scheduler.capacity.root.acl_administer_queue" : "*", > "yarn.scheduler.capacity.queue-mappings-override.enable" : 'false', > "yarn.scheduler.capacity.root.default.capacity" : "100", > "yarn.scheduler.capacity.root.default.user-limit-factor" : "1", > "yarn.scheduler.capacity.root.queues" : "default", > "yarn.scheduler.capacity.root.capacity" : "100", > "yarn.scheduler.capacity.root.default.acl_submit_applications" : "*", > "yarn.scheduler.capacity.root.default.maximum-capacity" : "100", > "yarn.scheduler.capacity.node-locality-delay" : "40", > "yarn.scheduler.capacity.maximum-applications" : "10000", > "yarn.scheduler.capacity.root.default.state" : "RUNNING" > } > }, > {code} > But. there can be another scenario where passed-in 'capacity-scheduler' is like : > {code} > "capacity-scheduler" : { > "properties" : { > "capacity-scheduler" : null, > "yarn.scheduler.capacity.root.accessible-node-labels" : "*", > "yarn.scheduler.capacity.maximum-am-resource-percent" : "1", > "yarn.scheduler.capacity.root.acl_administer_queue" : "*", > "yarn.scheduler.capacity.queue-mappings-override.enable" : 'false', > "yarn.scheduler.capacity.root.default.capacity" : "100", > "yarn.scheduler.capacity.root.default.user-limit-factor" : "1", > "yarn.scheduler.capacity.root.queues" : "default", > "yarn.scheduler.capacity.root.capacity" : "100", > "yarn.scheduler.capacity.root.default.acl_submit_applications" : "*", > "yarn.scheduler.capacity.root.default.maximum-capacity" : "100", > "yarn.scheduler.capacity.node-locality-delay" : "40", > "yarn.scheduler.capacity.maximum-applications" : "10000", > "yarn.scheduler.capacity.root.default.state" : "RUNNING" > } > }, > {code} > Here, services['configurations']["capacity-scheduler"]["properties"]["capacity-scheduler"] is itself 'null'. > We get into reading capacity-scheduler configs as key-value only if we dont find configs passed in as single '\n' string at level services['configurations']["capacity-scheduler"]["properties"]["capacity-scheduler"]: -- This message was sent by Atlassian JIRA (v6.3.4#6332)