ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-16915) Storm Stack advisor should not make storm.topology.submission.notifier.plugin.class property required
Date Sat, 28 May 2016 03:23:12 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-16915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15305136#comment-15305136
] 

Hadoop QA commented on AMBARI-16915:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12806707/AMBARI-16915_branch-2.4.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in ambari-server.

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/7042//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/7042//console

This message is automatically generated.

> Storm Stack advisor should not make storm.topology.submission.notifier.plugin.class property
required
> -----------------------------------------------------------------------------------------------------
>
>                 Key: AMBARI-16915
>                 URL: https://issues.apache.org/jira/browse/AMBARI-16915
>             Project: Ambari
>          Issue Type: Bug
>    Affects Versions: 2.4.0
>            Reporter: Sivaguru Kannan
>         Attachments: AMBARI-16915_branch-2.4.patch
>
>
> The Ambari change, This is in reference with the change, https://github.com/apache/ambari/commit/89fd30b40f3108bfcbcc73eb2d74c94a2ba14a7a
which accidentally made the storm.topology.submission.notifier.plugin property mandatory.

> If the storm defaults yaml config does not set the property a " " value is set for the
property. This causes storm startup to fail with a Class Not Found exception when starting
with Ambari.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message