ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-16737) Add validation for alert name edit
Date Thu, 19 May 2016 15:23:13 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-16737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15291282#comment-15291282
] 

Hadoop QA commented on AMBARI-16737:
------------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12804776/AMBARI-16737.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in ambari-web.

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/6899//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/6899//console

This message is automatically generated.

> Add validation for alert name edit
> ----------------------------------
>
>                 Key: AMBARI-16737
>                 URL: https://issues.apache.org/jira/browse/AMBARI-16737
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-web
>    Affects Versions: trunk
>            Reporter: Sangeeta Ravindran
>            Assignee: Sangeeta Ravindran
>         Attachments: AMBARI-16737.patch, EditAlertNoValidation.jpg, EditAlertValidationWithFix.jpg
>
>
> 1. On the Ambari dashboard, navigate to Alerts. Click on an alert.
> 2. Click on the Edit button and note that there is no validation and you can enter characters
such as \, < etc.
> 3. Also note that you can enter more than 255 characters. However, if the number of characters
exceeds 255, an exception is thrown on the server side because the database column only allows
255 characters. The UI however does not restrict this and you get no error message. The value
in the UI gets reset to what it was before you added more than 255 characters since the update
failed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message