ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-16731) Should close file object in security.py
Date Thu, 26 May 2016 22:33:12 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-16731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303087#comment-15303087
] 

Hadoop QA commented on AMBARI-16731:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12805551/AMBARI-16731.1.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/6984//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/6984//console

This message is automatically generated.

> Should close file object in security.py
> ---------------------------------------
>
>                 Key: AMBARI-16731
>                 URL: https://issues.apache.org/jira/browse/AMBARI-16731
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-agent
>    Affects Versions: trunk
>            Reporter: Masahiro Tanaka
>            Priority: Minor
>              Labels: patch-available
>         Attachments: AMBARI-16371.patch, AMBARI-16731.1.patch
>
>
> {{reqSignCrt}} method opens CSR file with {{open}} function but that doesn't close it.
> And, {{loadSrvrCrt}} method opens a file but this is unclosed too.
> They waste resources and may cause a problem.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message