ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-16175) clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia
Date Tue, 03 May 2016 03:08:12 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-16175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15267996#comment-15267996
] 

Hadoop QA commented on AMBARI-16175:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12801859/AMBARI-16175.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in ambari-server.

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/6750//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/6750//console

This message is automatically generated.

> clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia
> ------------------------------------------------------------------------------
>
>                 Key: AMBARI-16175
>                 URL: https://issues.apache.org/jira/browse/AMBARI-16175
>             Project: Ambari
>          Issue Type: Sub-task
>          Components: ambari-agent, ambari-server
>    Affects Versions: 2.0.0, 2.1.0, 2.1.1
>            Reporter: Juanjo Marron
>            Assignee: Juanjo Marron
>            Priority: Critical
>             Fix For: 2.4.0
>
>         Attachments: AMBARI-16175.patch
>
>
> Python code at at common-services level used generic imports form resource_management
(from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be more specific,
such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This  subtask cleans up import * from resource_management and replace it for specific
imports for:
> Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia services 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message