Return-Path: X-Original-To: apmail-ambari-issues-archive@minotaur.apache.org Delivered-To: apmail-ambari-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 11ED619453 for ; Thu, 21 Apr 2016 22:49:13 +0000 (UTC) Received: (qmail 94516 invoked by uid 500); 21 Apr 2016 22:49:13 -0000 Delivered-To: apmail-ambari-issues-archive@ambari.apache.org Received: (qmail 94443 invoked by uid 500); 21 Apr 2016 22:49:13 -0000 Mailing-List: contact issues-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list issues@ambari.apache.org Received: (qmail 94420 invoked by uid 99); 21 Apr 2016 22:49:12 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Apr 2016 22:49:12 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D53122C1F5A for ; Thu, 21 Apr 2016 22:49:12 +0000 (UTC) Date: Thu, 21 Apr 2016 22:49:12 +0000 (UTC) From: "Keta Patel (JIRA)" To: issues@ambari.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (AMBARI-15979) Provide UI validation for widget_name and description fields in Create/Edit Widget pop-up. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AMBARI-15979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keta Patel updated AMBARI-15979: -------------------------------- Status: Open (was: Patch Available) > Provide UI validation for widget_name and description fields in Create/Edit Widget pop-up. > ------------------------------------------------------------------------------------------ > > Key: AMBARI-15979 > URL: https://issues.apache.org/jira/browse/AMBARI-15979 > Project: Ambari > Issue Type: Improvement > Components: ambari-web > Affects Versions: trunk > Reporter: Keta Patel > Assignee: Keta Patel > Attachments: AMBARI-15979-April-20.patch, AMBARI-15979-inlineError.patch, AMBARI-15979-topError.patch, AMBARI-15979.patch, create_widget_button_location.tiff, create_widget_step1.tiff, create_widget_step2.tiff, create_widget_step3.tiff, fixed_ErrorOnTop_character_validation_for_description.tiff, fixed_ErrorOnTop_character_validation_for_name.tiff, fixed_ErrorOnTop_length_validation_for_description.tiff, fixed_ErrorOnTop_length_validation_for_name.tiff, fixed_InlineError_character_validation_for_description.tiff, fixed_InlineError_character_validation_for_name.tiff, fixed_InlineError_length_validation_for_description.tiff, fixed_InlineError_length_validation_for_name.tiff, fixed_characters_allowed_for_description.tiff, fixed_characters_allowed_for_name.tiff, original_characters_allowed_for_name_and_description.tiff, original_length_validation_for_description.tiff, original_length_validation_for_name.tiff > > > The UI validation at present checks only the length of the user input for widget_name and description fields. All characters are allowed to be stored in the database through them. A more strict UI validation that limits the type of characters entered for these fields will provide a good first line of defense. > Steps to reproduce: > 1. Make sure you have Ambari Metrics service installed on your cluster. > 2. On the Dashboard, select any service that makes use of Ambari Metrics, say HDFS. > 3. In the "Metrics" section, click the "Actions" button in the top-right corner, and select "Create a new widget" option from the drop-down. (attachment: create_widget_button_location.tiff) > 4. Create widget pop-up is displayed. > 5. On Step-1, select any type for the widget and click "Next". (attachment: create_widget_step1.tiff) > 6. On Step-2, select any valid metrics parameter and click "Next". (attachment: create_widget_step2.tiff) > 7. On Step-3, for widget_name and description fields, you can enter any character. No validation is present to check the contents. The only validation present checks the length of the input text. > (attachments: > create_widget_step3.tiff, > original_characters_allowed_for_name_and_description.tiff, > original_length_validation_for_name.tiff, > original_length_validation_for_description.tiff ) -- This message was sent by Atlassian JIRA (v6.3.4#6332)