ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-15965) Recommendation returns OK response if stack_advisor.py has SyntaxError
Date Tue, 19 Apr 2016 09:14:25 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-15965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15247412#comment-15247412
] 

Hadoop QA commented on AMBARI-15965:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12799465/AMBARI-15965.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The test build failed in ambari-server 

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/6526//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/6526//console

This message is automatically generated.

> Recommendation returns OK response if stack_advisor.py has SyntaxError
> ----------------------------------------------------------------------
>
>                 Key: AMBARI-15965
>                 URL: https://issues.apache.org/jira/browse/AMBARI-15965
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>            Reporter: Daniel Gergely
>            Assignee: Daniel Gergely
>         Attachments: AMBARI-15965.patch
>
>
> In the case of having a syntax error in a stack_advisor.py, it is swallowed and call
is returned with exit code 0.
> This means that configuration changes before the syntax error are applied, but  changes
after the syntax error are skipped.
> As a result the browser call returns with the response of 200 OK and configuration that
looks to be correct, but it might be incorrect, since parts of the stack advisor is skipped.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message