ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Antonenko Alexander (JIRA)" <j...@apache.org>
Subject [jira] [Reopened] (AMBARI-15724) Integrate Version Registration in Select Stack Page
Date Thu, 21 Apr 2016 12:20:25 GMT

     [ https://issues.apache.org/jira/browse/AMBARI-15724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Antonenko Alexander reopened AMBARI-15724:
------------------------------------------

I reverted this, as it breaks a lot of things thru all UI

In this patch we removed check that was prevented us from sending create cluster request in
any other place other than install wiz.

createCluster: function () {
    *if (this.get('content.controllerName') !== 'installerController') return;*
    .......

For example now on Add Service wiz we send cluster create request.

------------------
One more thing that makes some of the wizards being blocked:

ambari-web/app/controllers/wizard/step8_controller.js:

{code}
  /**
   * To Start deploy process
   * @method startDeploy
   */
  startDeploy: function () {
    var versionData = this.getSelectedRepoVersionData();
    var installerController = App.router.get('installerController');
    var self = this;
    installerController.postVersionDefinitionFileStep8(versionData.isXMLdata, versionData.data).done(function
(versionInfo) {
      if (versionInfo.id && versionInfo.stackName && versionInfo.stackVersion)
{
        var selectedStack = App.Stack.find().findProperty('isSelected', true);
        installerController.updateRepoOSInfo(versionInfo, selectedStack).done(function() {
          self._startDeploy();
        });
      }
    });
  },
{code}

versionData will be undefined for all wizards except install wiz 
and we will get app.js:40872 Uncaught TypeError: Cannot read property 'isXMLdata' of undefined

because:
{code}
/**
   * Get the the repo version (to install) info, this data will be POST
   * @method startDeploy
   */
  getSelectedRepoVersionData: function () {
    if (this.get('content.controllerName') !== 'installerController') return;
     .....
     .....
{code}

Example
add service review-step
click Deploy causes js-error and user is blocked
this issue may affects AHW also
"Back" and "Next" buttons are disabled

-----------
Another thing that we all face is that only 2.5 stack is available. Not sure if this is an
issue, maybe it is supposed to be so ?

-----------------

Minor issue that I found is when you select "Use Local Repository" and click on Select Version
dropdown (now it's HDP-2.5.0.0), despite its disabled, you can still click it and page will
reload. I saw this only once.

-----------

If you will go back from "Select Version" step and then on step0 click Next to return back
on step "Select Version" you will get an empty page that is broken.

 js error :app.js:212903 Uncaught TypeError: Cannot read property 'findProperty' of undefined

error happens in line "return this.get('controller.content.stacks').findProperty('id', selectedId);"
of function selectedPublicRepoVersion. 

this.get('controller.content.stacks') = undefined
And that's why findProperty fails upon undefined.
-------


> Integrate Version Registration in Select Stack Page
> ---------------------------------------------------
>
>                 Key: AMBARI-15724
>                 URL: https://issues.apache.org/jira/browse/AMBARI-15724
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-web
>    Affects Versions: 2.4.0
>            Reporter: Xi Wang
>            Assignee: Xi Wang
>            Priority: Critical
>             Fix For: 2.4.0
>
>         Attachments: AMBARI-15724.patch, AMBARI-15724.patch, version1.patch, version2.patch,
version3.patch, version4.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message