Return-Path: X-Original-To: apmail-ambari-issues-archive@minotaur.apache.org Delivered-To: apmail-ambari-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E7EDF181BA for ; Fri, 25 Mar 2016 11:16:25 +0000 (UTC) Received: (qmail 87966 invoked by uid 500); 25 Mar 2016 11:16:25 -0000 Delivered-To: apmail-ambari-issues-archive@ambari.apache.org Received: (qmail 87934 invoked by uid 500); 25 Mar 2016 11:16:25 -0000 Mailing-List: contact issues-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list issues@ambari.apache.org Received: (qmail 87916 invoked by uid 99); 25 Mar 2016 11:16:25 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Mar 2016 11:16:25 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 7D1352C14F8 for ; Fri, 25 Mar 2016 11:16:25 +0000 (UTC) Date: Fri, 25 Mar 2016 11:16:25 +0000 (UTC) From: "Antonenko Alexander (JIRA)" To: issues@ambari.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Reopened] (AMBARI-12906) Alert notifications are created even if credential fields are left empty MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AMBARI-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antonenko Alexander reopened AMBARI-12906: ------------------------------------------ Before creating new util methods/functions, please do investigation, to check if we already have that functionality. In this commit you added isEmptyOrSpaces. There is no need in it. We already have Em.isBlank. please remove isEmptyOrSpaces and use Em.isBlank instead. p.s. One more thing, next time you ask to make a review thru email please inform that there is no need in it, because additionally you asked someone else and he already did that. So we will escape doing double job. > Alert notifications are created even if credential fields are left empty > ------------------------------------------------------------------------ > > Key: AMBARI-12906 > URL: https://issues.apache.org/jira/browse/AMBARI-12906 > Project: Ambari > Issue Type: Bug > Components: alerts > Affects Versions: 2.1.0 > Reporter: Chandana Mirashi > Assignee: Qin Liu > Fix For: 2.4.0 > > Attachments: AMBARI-12906.patch > > > User should not be allowed to save changes if the credential fields are left empty when creating new Alert Notifications. > Steps to reproduce: > 1. Create New Alert Notification > 2. Enter Name = test > 3. Tick the checkbox for 'Use Authentication' > 4. Keep username and password empty > 5. Click on Save > 6. New alert notifications is created. -- This message was sent by Atlassian JIRA (v6.3.4#6332)