ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-15515) Improve Em.computed.getByKey
Date Wed, 23 Mar 2016 02:32:25 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-15515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207767#comment-15207767
] 

Hadoop QA commented on AMBARI-15515:
------------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12794779/AMBARI-15515.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 9 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in ambari-web.

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/5980//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/5980//console

This message is automatically generated.

> Improve Em.computed.getByKey
> ----------------------------
>
>                 Key: AMBARI-15515
>                 URL: https://issues.apache.org/jira/browse/AMBARI-15515
>             Project: Ambari
>          Issue Type: Task
>          Components: ambari-web
>    Affects Versions: 2.4.0
>            Reporter: Oleg Nechiporenko
>            Assignee: Oleg Nechiporenko
>             Fix For: 2.4.0
>
>         Attachments: AMBARI-15515.patch
>
>
> * Should handle default value when there is no key in the object
> {noformat}
> var o = Em.Object.create({
>     p1: {a: 1, b: 2, c: 3},
>     p2: 'd',
>     p3: Em.computed.getByKey('p1', 'p2', 100500)
> });
> console.log(o.get('p3')); // 100500 - default value is returned, because there is no
key `d` in the `p1`
> {noformat}
> * {{App.TestAliases.testAsComputedGetByKey}} should supports checking default value and
should be able to process provided map instead of traversing throw tested object
> * {{App.TestAliases.testAsComputedGetByKey}} should use `to.be.eql` instead of `to.be.equal`
(`equal` doesn't work for objects, arrays etc)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message