ambari-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-15408) Expose View Stream Provider Timeouts As Configuration Options
Date Tue, 15 Mar 2016 16:12:33 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15195564#comment-15195564
] 

Hudson commented on AMBARI-15408:
---------------------------------

FAILURE: Integrated in Ambari-trunk-Commit #4496 (See [https://builds.apache.org/job/Ambari-trunk-Commit/4496/])
AMBARI-15408. Expose View Stream Provider Timeouts As Configuration (dipayan.bhowmick: [http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=2ac0c1da5a5451b672446c125c48de69f1ca25ec])
* ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java
* ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
* ambari-server/conf/unix/ambari.properties


> Expose View Stream Provider Timeouts As Configuration Options
> -------------------------------------------------------------
>
>                 Key: AMBARI-15408
>                 URL: https://issues.apache.org/jira/browse/AMBARI-15408
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>    Affects Versions: 2.0.0
>            Reporter: DIPAYAN BHOWMICK
>            Assignee: DIPAYAN BHOWMICK
>             Fix For: 2.2.2
>
>         Attachments: AMBARI-15408.branch-2.2.patch
>
>
> The {{ViewRegistry}} instantiates view instances with a fixed timeout value for all remote
requests:
> {code}
>      ComponentSSLConfiguration sslConfiguration = ComponentSSLConfiguration.instance();
>      org.apache.ambari.server.controller.internal.URLStreamProvider streamProvider =
>          new org.apache.ambari.server.controller.internal.URLStreamProvider(
>             DEFAULT_REQUEST_CONNECT_TIMEOUT,
>             DEFAULT_REQUEST_READ_TIMEOUT,
>              sslConfiguration.getTruststorePath(),
>              sslConfiguration.getTruststorePassword(),
>              sslConfiguration.getTruststoreType());
> {code}
> Since we already expose UrlStreamProvider timeout values, we should either:
> 1) Also expose separate properties for view providers
> 2) Re-use the configuration options for the UrlStreamProviders
> {code}
>      ComponentSSLConfiguration sslConfiguration = ComponentSSLConfiguration.instance();
>      org.apache.ambari.server.controller.internal.URLStreamProvider streamProvider =
>          new org.apache.ambari.server.controller.internal.URLStreamProvider(
> +            configuration.getRequestConnectTimeout(),
> +            configuration.getRequestReadTimeout(),
>              sslConfiguration.getTruststorePath(),
>              sslConfiguration.getTruststorePassword(),
>              sslConfiguration.getTruststoreType());
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message