Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Subject: Reminder on Code Review Best Practices
MIME-Version: 1.0
From: Alejandro Fernandez <afernandez@hortonworks.com>
To: "dev@ambari.apache.org" <dev@ambari.apache.org>
Thread-Topic: Reminder on Code Review Best Practices
Thread-Index: AQHR7niR4JPOR1npo0GlbTvGv9hddg==
Date: Thu, 4 Aug 2016 17:49:38 +0000
Message-ID: <D3C8CF16.81E0C%afernandez@hortonworks.com>
Accept-Language: en-US
Content-Language: en-US
user-agent: Microsoft-MacOutlook/14.4.4.140807
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [192.175.27.10]
x-source-routing-agent: Processed
Content-Type: multipart/alternative;
	boundary="_000_D3C8CF1681E0Cafernandezhortonworkscom_"
archived-at: Thu, 04 Aug 2016 17:49:46 -0000

--_000_D3C8CF1681E0Cafernandezhortonworkscom_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Hi all,

This is a friendly reminder on our code review best practices.
https://cwiki.apache.org/confluence/display/AMBARI/Code+Review+Guidelines

* Whenever possible, the reviewer should be the first to annotate the code =
review to make it easier for others to read, i.e., help them help you.
* For larger patches, please allow 24 hours in code review so other develop=
ers have gotten a chance to look at it, especially if they are in a differe=
nt time zone.
* Include the right developers in the review, run git blame to see who last=
 modified the changed files and take a look at the chart from the link abov=
e to include developers interested in that area.

Thank you,
Alejandro Fernandez


--_000_D3C8CF1681E0Cafernandezhortonworkscom_--