ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alejandro Fernandez <afernan...@hortonworks.com>
Subject Reminder on Code Review Best Practices
Date Thu, 04 Aug 2016 17:49:38 GMT
Hi all,

This is a friendly reminder on our code review best practices.
https://cwiki.apache.org/confluence/display/AMBARI/Code+Review+Guidelines

* Whenever possible, the reviewer should be the first to annotate the code review to make
it easier for others to read, i.e., help them help you.
* For larger patches, please allow 24 hours in code review so other developers have gotten
a chance to look at it, especially if they are in a different time zone.
* Include the right developers in the review, run git blame to see who last modified the changed
files and take a look at the chart from the link above to include developers interested in
that area.

Thank you,
Alejandro Fernandez


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message