ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sumit Mohanty <smoha...@hortonworks.com>
Subject Re: Code Review groups
Date Thu, 02 Jun 2016 21:02:55 GMT
We can look into the already available component names in the JIRA for the initial list. 
We should not create fine-grained groups and aim to have at least 3-5 devs (more is better)
in a single component/area.

Possible list:
ambari-web
ambari-views
ambari-server
ambari-agent
stacks-framework/extensibility
stack-definitions (this could break into separate services)
blueprints
alerts/metrics
logsearch
security/kerberos/ldap
stack-upgrade/RU/EU

Once the list is final lets make sure that the available list of components in the JIRA matches
this list.

This is probably also a good opportunity to see if there are better alternatives to reviews.apache.org.

regards
Sumit
________________________________________
From: Jayush Luniya <jluniya@hortonworks.com>
Sent: Thursday, June 02, 2016 1:47 PM
To: dev@ambari.apache.org
Subject: Re: Code Review groups

+1 on this


On 6/2/16, 1:44 PM, "Swapan Shridhar" <sshridhar@hortonworks.com> wrote:

>+1. Makes sense.
>
>Thanks.
>
>Regards,
>Swapan.
>
>
>
>
>
>
>
>
>
>On 6/2/16, 1:27 PM, "Robert Levas" <rlevas@hortonworks.com> wrote:
>
>>Alejandro, I agree.  I just hope we (as a group) can manage the wiki
>>page without letting it get too stale over time.
>>
>>+1
>>
>>Rob
>>
>>
>>On 6/2/16, 12:55 PM, "Alejandro Fernandez" <afernandez@hortonworks.com>
>>wrote:
>>
>>>Hi committers and contributors,
>>>
>>>I'm sure most of you have ran into this before; whenever I submit a
>>>code review I'm always curious to find out which reviewers I should
>>>include that are knowledgeable in that area.
>>>So I'll typically run git blame to find the last 2-3 people that worked
>>>on those files, which takes time and may include reviewers no longer
>>>interested in that code area or miss reviewers that are interested.
>>>I want to propose a wiki where developers sign up to be reviewers for a
>>>particular section, could be a feature, directory, etc.
>>>
>>>Thoughts?
>>>
>>>This allows developers to opt-in to areas of interest (even outside of
>>>their current expertise), should produce better code reviews, and make
>>>it easier for new contributors to find the right people.
>>>
>>>Thank you,
>>>Alejandro Fernandez
>>>
>>


Mime
View raw message