Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4287218707 for ; Fri, 4 Mar 2016 15:56:14 +0000 (UTC) Received: (qmail 38964 invoked by uid 500); 4 Mar 2016 15:56:14 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 38926 invoked by uid 500); 4 Mar 2016 15:56:14 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 38911 invoked by uid 99); 4 Mar 2016 15:56:13 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Mar 2016 15:56:13 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 541DC2E82CB; Fri, 4 Mar 2016 15:56:13 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2188450271053669696==" MIME-Version: 1.0 Subject: Re: Review Request 44373: Capture HDFS metrics per RPC port number in AMS and Grafana From: Aravindan Vijayan To: Sumit Mohanty , Dmytro Sen , Aravindan Vijayan Cc: Sid Wagle , Ambari Date: Fri, 04 Mar 2016 15:56:13 -0000 Message-ID: <20160304155613.7389.69671@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Aravindan Vijayan X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/44373/ X-Sender: Aravindan Vijayan X-ReviewBoard-ShipIt: 1 References: <20160304012852.7389.86277@reviews.apache.org> In-Reply-To: <20160304012852.7389.86277@reviews.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Aravindan Vijayan X-ReviewRequest-Repository: ambari --===============2188450271053669696== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44373/#review122088 ----------------------------------------------------------- Ship it! Ship It! - Aravindan Vijayan On March 4, 2016, 1:28 a.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44373/ > ----------------------------------------------------------- > > (Updated March 4, 2016, 1:28 a.m.) > > > Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty. > > > Bugs: AMBARI-15293 > https://issues.apache.org/jira/browse/AMBARI-15293 > > > Repository: ambari > > > Description > ------- > > For rpc metrics the port number determines what rpc calls are being tracked. > _Example_: Namenode can have different rpc ports for Datanode and clients and healthchecks. Presently since the port number is not a part of the metricsName the two metric entries will step on each other in AMS store. > > This patch only addresses the fix for HDFS. > > > Diffs > ----- > > ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java b2810b7 > ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java 6da9257 > ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java 528384e > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProvider.java 3dbe0a8 > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java c1b9c50 > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java cefe953 > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java b8d47f9 > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 7e93a6e > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py dc71408 > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hadoop-metrics2.properties.j2 f9c2164 > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProviderTest.java f4c212c > ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/PropertyHelperTest.java d450177 > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 5445b32 > > Diff: https://reviews.apache.org/r/44373/diff/ > > > Testing > ------- > > Manaully ran affected unit tests. > Manually tested all individual change areas. > > ---------------------------------------------------------------------- > Ran 244 tests in 7.160s > > OK > ---------------------------------------------------------------------- > Total run:893 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Sid Wagle > > --===============2188450271053669696==--