Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6232118637 for ; Wed, 2 Mar 2016 19:27:51 +0000 (UTC) Received: (qmail 94332 invoked by uid 500); 2 Mar 2016 19:27:51 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 94301 invoked by uid 500); 2 Mar 2016 19:27:51 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 94272 invoked by uid 99); 2 Mar 2016 19:27:50 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Mar 2016 19:27:50 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B59642E7B39; Wed, 2 Mar 2016 19:27:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3180032260206999803==" MIME-Version: 1.0 Subject: Re: Review Request 44238: Ambari config update does not handle removals properly From: Matt To: jun aoki , bhuvnesh chaudhary , Jaimin Jetly , Alejandro Fernandez , Robert Levas , Srimanth Gunturi , Jayush Luniya , Newton Alex , Oleksandr Diachenko , Alexander Denissov , Goutam Tadi , Sumit Mohanty , Matt Cc: Lav Jain , Ambari Date: Wed, 02 Mar 2016 19:27:50 -0000 Message-ID: <20160302192750.1648.29267@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Matt X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/44238/ X-Sender: Matt X-ReviewBoard-ShipIt: 1 References: <20160301235408.6191.50995@reviews.apache.org> In-Reply-To: <20160301235408.6191.50995@reviews.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Matt X-ReviewRequest-Repository: ambari --===============3180032260206999803== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44238/#review121698 ----------------------------------------------------------- Ship it! Ship It! - Matt On March 1, 2016, 3:54 p.m., Lav Jain wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44238/ > ----------------------------------------------------------- > > (Updated March 1, 2016, 3:54 p.m.) > > > Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Jayush Luniya, Matt, Newton Alex, Oleksandr Diachenko, Robert Levas, Sumit Mohanty, and Srimanth Gunturi. > > > Bugs: AMBARI-15254 > https://issues.apache.org/jira/browse/AMBARI-15254 > > > Repository: ambari > > > Description > ------- > > ConfigHelper.updateConfigType takes in config_type (e.g. hdfs-site), map of updates (key value pairs) and a list of removals (properties). > > The current implementation is skipping the updates to configuration if the Map of updates is empty, even if there are properties to be removed. > > This is causing problem during disabling of kerberos for some components (like HAWQ) because some config parameters that are present in kerberos.json must be removed. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java d311017 > ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java 9fe0fc3 > > Diff: https://reviews.apache.org/r/44238/diff/ > > > Testing > ------- > > Test case added. > > > Thanks, > > Lav Jain > > --===============3180032260206999803==--