Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 39F0B18B2D for ; Wed, 2 Mar 2016 16:43:31 +0000 (UTC) Received: (qmail 31671 invoked by uid 500); 2 Mar 2016 16:43:31 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 31654 invoked by uid 500); 2 Mar 2016 16:43:31 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 31638 invoked by uid 99); 2 Mar 2016 16:43:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Mar 2016 16:43:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 840562E7A9B; Wed, 2 Mar 2016 16:43:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2101246772951282267==" MIME-Version: 1.0 Subject: Re: Review Request 38095: Ambari UI shows "Corrupted Blocks" but it is "Corrupted replica" From: Jaimin Jetly To: Daniel Gergely , Jaimin Jetly , Laszlo Puskas , Yusaku Sako Cc: Oliver Szabo , Ambari Date: Wed, 02 Mar 2016 16:43:30 -0000 Message-ID: <20160302164330.1648.51192@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jaimin Jetly X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38095/ X-Sender: Jaimin Jetly X-ReviewBoard-ShipIt: 1 References: <20160216115455.13178.14713@reviews.apache.org> In-Reply-To: <20160216115455.13178.14713@reviews.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Jaimin Jetly X-ReviewRequest-Repository: ambari --===============2101246772951282267== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38095/#review121669 ----------------------------------------------------------- Ship it! Ship It! - Jaimin Jetly On Feb. 16, 2016, 11:54 a.m., Oliver Szabo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38095/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2016, 11:54 a.m.) > > > Review request for Ambari, Daniel Gergely, Jaimin Jetly, Laszlo Puskas, and Yusaku Sako. > > > Bugs: AMBARI-12931 > https://issues.apache.org/jira/browse/AMBARI-12931 > > > Repository: ambari > > > Description > ------- > > Problem: > > - Corrupted Block metric on the UI means corrupted replicas. > > Solution: > > - In fact this metric comes from hadoop: > > FSNamesystem.java: > > @Metric({"CorruptBlocks", "Number of blocks with corrupt replicas"}) > public long getCorruptReplicaBlocks() { > return blockManager.getCorruptReplicaBlocksCount(); > } > - Because of that "CorruptedBlock" references are correct on the ambari side. I suggest only UI change, what clarifies the definition. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java 2ea326a > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 7e93a6e > ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json 1010128 > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java 608a348 > ambari-web/app/assets/data/widget_layouts/HDFS_SUMMARY.json a97c9e5 > ambari-web/app/messages.js 08ff073 > > Diff: https://reviews.apache.org/r/38095/diff/ > > > Testing > ------- > > Unit testing done. > > > Thanks, > > Oliver Szabo > > --===============2101246772951282267==--