Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============7702179122167537595=="
MIME-Version: 1.0
Subject: Review Request 44213: Collision between HBase Master and RS metrics
From: Sid Wagle <swagle@hortonworks.com>
To: Sumit Mohanty <smohanty@hortonworks.com>,
 Dmytro Sen <dsen@hortonworks.com>,
 Aravindan Vijayan <avijayan@hortonworks.com>
Cc: Sid Wagle <swagle@hortonworks.com>, Ambari <dev@ambari.apache.org>
Date: Tue, 01 Mar 2016 17:28:10 -0000
Message-ID: <20160301172810.26940.71826@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Sid Wagle <noreply@reviews.apache.org>
Reply-To: Sid Wagle <swagle@hortonworks.com>

--===============7702179122167537595==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44213/
-----------------------------------------------------------

Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty.


Bugs: AMBARI-15250
    https://issues.apache.org/jira/browse/AMBARI-15250


Repository: ambari


Description
-------

Found out that Ganglia added the processName in JVM metrics to make this distinction::

org.apache.hadoop.metrics.ganglia.GangliaContext#emitRecord

{code}
// Setup so that the records have the proper leader names so they are
    // unambiguous at the ganglia level, and this prevents a lot of rework
    StringBuilder sb = new StringBuilder();
    sb.append(contextName);
    sb.append('.');

    if (contextName.equals("jvm") && outRec.getTag("processName") != null) {
      sb.append(outRec.getTag("processName"));
      sb.append('.');
    }
{code}

This is missing from our Sink which means some metrics do not have unique names and will collide. _Affects HBase only_


Diffs
-----

  ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java 6da9257 

Diff: https://reviews.apache.org/r/44213/diff/


Testing
-------

Manually verified metric names for JVM:

| jvm.Master.JvmMetrics.GcCount            |
| jvm.Master.JvmMetrics.GcCountConcurrentMarkSweep |
| jvm.RegionServer.JvmMetrics.GcCountParNew |
| jvm.RegionServer.JvmMetrics.GcTimeMillis |


Thanks,

Sid Wagle


--===============7702179122167537595==--