ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jonathan Hurley <jhur...@hortonworks.com>
Subject Re: Review Request 44459: Kerberos: Provide SHA256 or SHA512 options for template principal digest
Date Mon, 07 Mar 2016 22:30:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44459/#review122394
-----------------------------------------------------------


Ship it!





ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java
(lines 272 - 273)
<https://reviews.apache.org/r/44459/#comment184363>

    Where do these values get used/exposed? Generating them is fine, but is there another
Jira tracking how they are consumed?


- Jonathan Hurley


On March 7, 2016, 12:53 p.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44459/
> -----------------------------------------------------------
> 
> (Updated March 7, 2016, 12:53 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, and Sandor
Magyari.
> 
> 
> Bugs: AMBARI-15316
>     https://issues.apache.org/jira/browse/AMBARI-15316
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When generating accounts in an Active Directory, it may be useful to add a unique value
to CN's.  In the past generating this value was done by taking the SHA1 hash of the relevant
normalized principal name. For example {{ambari-qa-c1@EXAMPLE.COM}} yields {{d9b48cb1c075d3da9fab4855a4031266bab8fb6a}}.
 
> 
> Because using SHA1 at all may not be desirable, Ambari should provide options to use
the following digest algorithms in the Active Directory account creation attribute template
({{kerberos-env/ad_create_attributes_template}}:
> 
> Attribute Variables  |Example
> ---------------------|------------------------------------------
> $principal_digest    |SHA1 hash of the $normalized_principal
> $principal_digest_256|SHA256 hash of the $normalized_principal
> $principal_digest_512|SHA512 hash of the $normalized_principal
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java
a1e1544 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandlerTest.java
0622807 
> 
> Diff: https://reviews.apache.org/r/44459/diff/
> 
> 
> Testing
> -------
> 
> # Local test results:
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:07:01.482s
> [INFO] Finished at: Mon Mar 07 12:47:02 EST 2016
> [INFO] Final Memory: 58M/799M
> [INFO] ------------------------------------------------------------------------
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message