ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Di Li <d...@ca.ibm.com>
Subject Re: Review Request 44457: AMBARI-15310: Host Service Summary Page does not display long service names well
Date Mon, 07 Mar 2016 22:24:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review122390
-----------------------------------------------------------




ambari-web/app/templates/main/host/details/host_component.hbs (line 40)
<https://reviews.apache.org/r/44457/#comment184361>

    In additional to a fixed width (number of chars) field, it'd also be much more flexible
to use a flyout. User simply mouses over the component name and the flyout  appears with the
fullname. User mouses away from the component name, the flyout disappears.


- Di Li


On March 7, 2016, 9:57 p.m., Keta Patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> -----------------------------------------------------------
> 
> (Updated March 7, 2016, 9:57 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-15310
>     https://issues.apache.org/jira/browse/AMBARI-15310
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In Ambari UI, navigate to Hosts and click on the hostname where the service is installed.
The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon etc. spills
to the next line (see attachment "Original spacing with long service name").
> Also, note the indentation of the last button for Clients does not align well with the
buttons above it.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/styles/application.less 755dff2 
>   ambari-web/app/templates/main/host/details/host_component.hbs 60031de 
>   ambari-web/app/templates/main/host/summary.hbs 17a0b69 
> 
> Diff: https://reviews.apache.org/r/44457/diff/
> 
> 
> Testing
> -------
> 
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component was fixed
in a <div> tag.
> The fix here also uses a similar approach where every component is surrounded by a <div>
tag and the width is fixed for them so that the appear in their respective positions regardless
of the length of service names. I have also adjusted the width of the left <div> component
with "span8" instead of "span7" and the right <div> component of the button to "span4"
instead of "span5" to better adjust the spacing.
> 
> TESTS:
> No tests are written for these changes as the fix involves updates in the stylesheet.
> However, the changes were tested by zooming in and out and checking if the icons and
names were contained in their respective blocks and not overlapping with other <div>
blocks.
> 
> 
> The following is the result of running ambari-web tests:
> 
>   24565 tests complete (28 seconds)
>   145 tests pending
> 
> 
> File Attachments
> ----------------
> 
> AMBARI-15310 (patch-2)
>   https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
> 
> 
> Thanks,
> 
> Keta Patel
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message