ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alejandro Fernandez <afernan...@hortonworks.com>
Subject Re: Review Request 44272: Install & Manage Zeppelin with Ambari
Date Mon, 07 Mar 2016 19:37:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44272/#review122348
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/configuration/zeppelin-config.xml
(line 47)
<https://reviews.apache.org/r/44272/#comment184307>

    Typo here, "e.g.,"



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/metainfo.xml (line
48)
<https://reviews.apache.org/r/44272/#comment184304>

    All of these packages should go in HDP-UTILS instead



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/metainfo.xml (line
63)
<https://reviews.apache.org/r/44272/#comment184314>

    Zeppelin package should have the version in the name.



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/master.py
(line 34)
<https://reviews.apache.org/r/44272/#comment184308>

    Why reload sys?



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/master.py
(line 43)
<https://reviews.apache.org/r/44272/#comment184309>

    Can we find this through another means that's deterministic?



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/master.py
(line 46)
<https://reviews.apache.org/r/44272/#comment184310>

    The rpm is responsible for creating the user.



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/master.py
(line 49)
<https://reviews.apache.org/r/44272/#comment184315>

    This is bound to fail in firewalled networks. Will need to figure out a way to include
these in HDP UTILS and still be able to pip-install them.
    
    We cannot ship these packages with Ambari due to BSD license on numpy, scipy, pandas,
scikit-learn, which has an advertisement clause.



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/master.py
(line 84)
<https://reviews.apache.org/r/44272/#comment184311>

    This function name is misleading.



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/master.py
(line 145)
<https://reviews.apache.org/r/44272/#comment184317>

    Eventally, this will need support for RU and EU. Ok with adding that in a follow-up patch.



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/master.py
(line 165)
<https://reviews.apache.org/r/44272/#comment184312>

    Use a marker file on the file system to know if the first-time setup was successful.



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/params.py
(line 70)
<https://reviews.apache.org/r/44272/#comment184316>

    spark_version is not defined in case of an exception.


- Alejandro Fernandez


On March 7, 2016, 7:09 p.m., Renjith Kamath wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44272/
> -----------------------------------------------------------
> 
> (Updated March 7, 2016, 7:09 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav
Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15265
>     https://issues.apache.org/jira/browse/AMBARI-15265
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - add service defnition for Apache Zeppelin
> - add support for Zeppelin view in Ambari
> - add alert config
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/alerts.json
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/configuration/zeppelin-config.xml
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/configuration/zeppelin-env.xml
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/kerberos.json
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/metainfo.xml
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/alert_check_zeppelin.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/master.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/params.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/setup_snapshot.sh
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/status_params.py
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json PRE-CREATION

>   ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml PRE-CREATION

>   contrib/views/pom.xml 627552a 
>   contrib/views/zeppelin/pom.xml PRE-CREATION 
>   contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java
PRE-CREATION 
>   contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp PRE-CREATION 
>   contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml PRE-CREATION 
>   contrib/views/zeppelin/src/main/resources/view.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44272/diff/
> 
> 
> Testing
> -------
> 
> - manual testing in vm
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message