ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Hill <greg.h...@rackspace.com>
Subject Re: Review Request 42031: [AMBARI-12915] Make agent hostname configurable
Date Mon, 07 Mar 2016 18:21:40 GMT


> On March 4, 2016, 8:43 p.m., Alejandro Fernandez wrote:
> > ambari-agent/src/main/python/ambari_agent/hostname.py, line 40
> > <https://reviews.apache.org/r/42031/diff/1/?file=1186440#file1186440line40>
> >
> >     There's already a script that can be called to change the hostname that is reported
to Ambari.

Yes, that is what we ended up using.  This patch was to make it easier and just put it in
the config file.  That's where I expected to be able to set it when I was debugging the issue.
 It still falls back to the script, if that's configured.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42031/#review122149
-----------------------------------------------------------


On Jan. 7, 2016, 8:17 p.m., Greg Hill wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42031/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2016, 8:17 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-12915
>     https://issues.apache.org/jira/browse/AMBARI-12915
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Adds an option to the agent config file to specify the hostname instead of relying on
the system hostname.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/hostname.py 9cb75d6 
>   ambari-agent/src/test/python/ambari_agent/TestHostname.py 3cf6b17 
> 
> Diff: https://reviews.apache.org/r/42031/diff/
> 
> 
> Testing
> -------
> 
> Added unit tests to confirm desired behavior.
> 
> 
> Thanks,
> 
> Greg Hill
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message