ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Hill <greg.h...@rackspace.com>
Subject Re: Review Request 42032: [AMBARI-12916] Make server hostname configurable
Date Mon, 07 Mar 2016 18:19:44 GMT


> On March 4, 2016, 4:30 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java,
line 303
> > <https://reviews.apache.org/r/42032/diff/1/?file=1186443#file1186443line303>
> >
> >     This probably does not compile since `getApiHostname()` returns a `String` and
the `if` clause is looking for a `boolean` value.

Ah, should it be this instead?

if (configs.getApiHostname() != null) {


> On March 4, 2016, 4:30 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java,
lines 303-308
> > <https://reviews.apache.org/r/42032/diff/1/?file=1186443#file1186443line303>
> >
> >     The result of this should be logged as `INFO` so that when problems occurr we
can know what the cluster is using as the `masterHostname` when looking at the logs.

Ok, I'll add some logging.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42032/#review122099
-----------------------------------------------------------


On Jan. 7, 2016, 8:23 p.m., Greg Hill wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42032/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2016, 8:23 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-12916
>     https://issues.apache.org/jira/browse/AMBARI-12916
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This lets you configure the hostname that the Ambari server passes to the views and agent
so you can specify it differently from the system hostname.  This is useful in cases where
you want to use a fqdn for API access but a local hostname for local cluster communication.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
371d5d2 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
a7f206a 
> 
> Diff: https://reviews.apache.org/r/42032/diff/
> 
> 
> Testing
> -------
> 
> Honestly, not much.  There weren't any existing unit tests for the code I modified and
I'm not a Java developer so I didn't really know where to start with creating them.  It's
a pretty simple change and doesn't break any existing tests, but I'm happy to do some more
testing if someone can provide some direction.
> 
> 
> Thanks,
> 
> Greg Hill
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message