ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sumit Mohanty <smoha...@hortonworks.com>
Subject Re: Review Request 44272: Install & Manage Zeppelin with Ambari
Date Thu, 03 Mar 2016 02:46:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44272/#review121773
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/alert_check_zeppelin.py
(line 4)
<https://reviews.apache.org/r/44272/#comment183602>

    This alert is just checking for Zeppelin PID. This is not needed. status() command is
enough. If Zepplin has a listen port then we need alerts that go against the port - see WEB
or PORT type alerts in HBase and HDFS



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py
(line 145)
<https://reviews.apache.org/r/44272/#comment183603>

    Delete this line.



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py
(line 157)
<https://reviews.apache.org/r/44272/#comment183604>

    Why OSX?



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py
(line 161)
<https://reviews.apache.org/r/44272/#comment183605>

    How did these files reach /tmp folder?



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py
(line 165)
<https://reviews.apache.org/r/44272/#comment183606>

    Need to use HdfsResource function call. We cannot rely on hdfs calls directly through
Execute.



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py
(line 171)
<https://reviews.apache.org/r/44272/#comment183607>

    Remove all echo statements. If you need to log then use Logger.info(). Anyway, we should
not need to read/print pid value.



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py
(line 186)
<https://reviews.apache.org/r/44272/#comment183608>

    Does the zeppelin pid file name change on every start? Could we create the name statically
in status_params.py and then use it everywhere.



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/setup_snapshot.sh
(line 1)
<https://reviews.apache.org/r/44272/#comment183600>

    When is this sh script used? Is it needed for Zeppelin start or install?



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/setup_snapshot.sh
(line 68)
<https://reviews.apache.org/r/44272/#comment183601>

    If Zeppelin needs hive-site then we should use the library in resource_management module
to do it.



ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml (line 24)
<https://reviews.apache.org/r/44272/#comment183598>

    It should be 0.6.0.2.5.0.0



ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml (line 26)
<https://reviews.apache.org/r/44272/#comment183599>

    You need to add 2.5 specific package names such as zeppelin_2_5_* and zeppelin-2-5-.*.
    
    See ambari-server/src/main/resources/stacks/HDP/2.5/services/HBASE/metainfo.xml


- Sumit Mohanty


On March 2, 2016, 4:54 p.m., Renjith Kamath wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44272/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 4:54 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav
Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15265
>     https://issues.apache.org/jira/browse/AMBARI-15265
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - add service defnition for Apache Zeppelin
> - add support for Zeppelin view in Ambari
> - add alert config
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/alerts.json PRE-CREATION

>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-ambari-config.xml
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-config.xml
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-env.xml
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/kerberos.json PRE-CREATION

>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/metainfo.xml PRE-CREATION

>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/alert_check_zeppelin.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/params.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/setup_snapshot.sh
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/status_params.py
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json PRE-CREATION

>   ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml PRE-CREATION

>   contrib/views/pom.xml 627552a 
>   contrib/views/zeppelin/pom.xml PRE-CREATION 
>   contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java
PRE-CREATION 
>   contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp PRE-CREATION 
>   contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml PRE-CREATION 
>   contrib/views/zeppelin/src/main/resources/view.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44272/diff/
> 
> 
> Testing
> -------
> 
> - manual testing in vm
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message