ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yusaku Sako <yus...@hortonworks.com>
Subject Re: Review Request 44253: Add a "Add" button to Repo management UI.
Date Wed, 02 Mar 2016 21:58:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44253/#review121731
-----------------------------------------------------------



Thanks for contributing this feature.  This is great.
Wearing my Hortoworks' hat, what do you think about adding a feature flag for this, so that
we can turn this feature on/off at build time via app/configs.js's App.supports object?  From
Hortonwork's perspective, when we build Ambari, we don't want to expose this just yet as we
will not have a chance to test this thoroughly in the 2.2.2 timeframe.  But I understand that
Pivotal and other vendors need this.

- Yusaku Sako


On March 2, 2016, 7:41 p.m., Matt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44253/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 7:41 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-13216
>     https://issues.apache.org/jira/browse/AMBARI-13216
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This patch adds a UI button to the Ambari Admin view which allows users to Add a repository
to an stack which is already installed on the cluster.
> 
> Steps to follow to add a new repository to the stack:
> - Add the new repository to HDP/x.y/repos/repoinfo.xml
> - Check if the new repository is available at the REST endpoint. Eg: http://c6401.ambari.apache.org:8080/api/v1/stacks/HDP/versions/2.4/operating_systems/redhat6/repositories
> - Go to Ambari Admin UI and add the repository.
> 
> **Screenshots:**
> 
> 
> ![Image 1](https://issues.apache.org/jira/secure/attachment/12790852/screenshot-1.png)
> 
> 
> ![Image 2](https://issues.apache.org/jira/secure/attachment/12790854/screenshot-2.png)
> 
> 
> Diffs
> -----
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/index.html fe049ac 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js
97a7696 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js
dcd79df 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/AddRepositoryModal.js
PRE-CREATION 
>   ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css ff963ee 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/modals/AddRepositoryModal.html
PRE-CREATION 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html
0c6ca84 
> 
> Diff: https://reviews.apache.org/r/44253/diff/
> 
> 
> Testing
> -------
> 
> Manually Tested.
> 
> 
> Thanks,
> 
> Matt
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message