ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jayush Luniya <jlun...@hortonworks.com>
Subject Re: Review Request 44285: AMBARI-15266 - Add configurable download retries for cache misses
Date Wed, 02 Mar 2016 20:27:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44285/#review121712
-----------------------------------------------------------




ambari-agent/src/main/python/ambari_agent/FileCache.py (line 198)
<https://reviews.apache.org/r/44285/#comment183494>

    See if you can use the retry decorator instead. 
    
    https://github.com/apache/ambari/blob/trunk/ambari-common/src/main/python/resource_management/libraries/functions/decorator.py#L29
    
    Sample Usage:
    https://github.com/apache/ambari/blob/trunk/ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py#L45


- Jayush Luniya


On March 2, 2016, 7:54 p.m., Greg Hill wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44285/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 7:54 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15266
>     https://issues.apache.org/jira/browse/AMBARI-15266
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Adds configuration options to tell ambari-agent to retry attempts to download the custom
script cache from ambari-server
> 
> 
> Diffs
> -----
> 
>   ambari-agent/conf/unix/ambari-agent.ini 80afdb2 
>   ambari-agent/conf/windows/ambari-agent.ini 1b24f25 
>   ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 2c82ca5 
>   ambari-agent/src/main/python/ambari_agent/FileCache.py b7c5dee 
>   ambari-agent/src/test/python/ambari_agent/TestFileCache.py 5933daa 
> 
> Diff: https://reviews.apache.org/r/44285/diff/
> 
> 
> Testing
> -------
> 
> New unit tests cover the behavior.
> 
> 
> Thanks,
> 
> Greg Hill
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message